Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setTargetTriple now accepts Triple rather than string #138137

Merged
merged 2 commits into from
Mar 8, 2025
Merged

setTargetTriple now accepts Triple rather than string #138137

merged 2 commits into from
Mar 8, 2025

Conversation

ZequanWu
Copy link
Contributor

@ZequanWu ZequanWu commented Mar 7, 2025

llvm/llvm-project#129868 updated setTargetTriple

@rustbot
Copy link
Collaborator

rustbot commented Mar 7, 2025

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 7, 2025
@cuviper cuviper added the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label Mar 7, 2025
@cuviper
Copy link
Member

cuviper commented Mar 7, 2025

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 7, 2025

📌 Commit 8814679 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 7, 2025
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Mar 7, 2025
@compiler-errors
Rollup merge of rust-lang#138137 - ZequanWu:fix-triple, r=cuviper
d3fdef6 
setTargetTriple now accepts Triple rather than string

llvm/llvm-project#129868 updated `setTargetTriple`
@compiler-errors compiler-errors mentioned this pull request Mar 7, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 7, 2025
@bors
Auto merge of rust-lang#138180 - compiler-errors:rollup-m8zqdep, r=co…
a7cae02 
…mpiler-errors

Rollup of 10 pull requests

Successful merges:

 - rust-lang#135651 (Support for `wasm32-wali-linux-musl` Tier-3 target)
 - rust-lang#136642 (Put the alloc unit tests in a separate alloctests package)
 - rust-lang#137337 (Add verbatim linker to AIXLinker)
 - rust-lang#137549 (Clean up various LLVM FFI things in codegen_llvm)
 - rust-lang#137957 (Remove i586-pc-windows-msvc)
 - rust-lang#138063 (Improve `-Zunpretty=hir` for parsed attrs)
 - rust-lang#138137 (setTargetTriple now accepts Triple rather than string)
 - rust-lang#138141 (tests: fix some typos in comment)
 - rust-lang#138150 (Streamline HIR intravisit `visit_id` calls for items)
 - rust-lang#138173 (Delay bug for negative auto trait rather than ICEing)

r? `@ghost`
`@rustbot` modify labels: rollup
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Mar 7, 2025
@compiler-errors
Rollup merge of rust-lang#138137 - ZequanWu:fix-triple, r=cuviper
3dafc37 
setTargetTriple now accepts Triple rather than string

llvm/llvm-project#129868 updated `setTargetTriple`
@compiler-errors compiler-errors mentioned this pull request Mar 7, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 7, 2025
@bors
Auto merge of rust-lang#138185 - compiler-errors:rollup-omp1jxu, r=co…
f8dca5c 
…mpiler-errors

Rollup of 8 pull requests

Successful merges:

 - rust-lang#136642 (Put the alloc unit tests in a separate alloctests package)
 - rust-lang#137337 (Add verbatim linker to AIXLinker)
 - rust-lang#137363 (compiler: factor Windows x86-32 ABI impl into its own file)
 - rust-lang#137685 (self-contained linker: conservatively default to `-znostart-stop-gc` on x64 linux)
 - rust-lang#138000 (atomic: clarify that failing conditional RMW operations are not 'writes')
 - rust-lang#138063 (Improve `-Zunpretty=hir` for parsed attrs)
 - rust-lang#138137 (setTargetTriple now accepts Triple rather than string)
 - rust-lang#138173 (Delay bug for negative auto trait rather than ICEing)

r? `@ghost`
`@rustbot` modify labels: rollup
@jhpratt jhpratt mentioned this pull request Mar 8, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 8, 2025
@bors
Auto merge of rust-lang#138202 - jhpratt:rollup-kqrl5xn, r=jhpratt
20f0108 
Rollup of 12 pull requests

Successful merges:

 - rust-lang#137337 (Add verbatim linker to AIXLinker)
 - rust-lang#137363 (compiler: factor Windows x86-32 ABI impl into its own file)
 - rust-lang#137537 (Prevent `rmake.rs` from using unstable features, and fix 3 run-make tests that currently do)
 - rust-lang#137606 (add a "future" edition)
 - rust-lang#137957 (Remove i586-pc-windows-msvc)
 - rust-lang#138000 (atomic: clarify that failing conditional RMW operations are not 'writes')
 - rust-lang#138013 (Add post-merge analysis CI workflow)
 - rust-lang#138033 (rustdoc: Add attribute-related tests for rustdoc JSON.)
 - rust-lang#138137 (setTargetTriple now accepts Triple rather than string)
 - rust-lang#138173 (Delay bug for negative auto trait rather than ICEing)
 - rust-lang#138184 (Allow anyone to relabel `CI-spurious-*`)
 - rust-lang#138187 (remove clones)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b160477 into rust-lang:master Mar 8, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 8, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 8, 2025
@rust-timer
Unrolled build for rust-lang#138137
558ab23 
Rollup merge of rust-lang#138137 - ZequanWu:fix-triple, r=cuviper

setTargetTriple now accepts Triple rather than string

llvm/llvm-project#129868 updated `setTargetTriple`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuviper cuviper cuviper left review comments

Assignees

@cuviper cuviper

Labels
llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ZequanWu @rustbot @cuviper @bors