Simplify printf and shell format suggestions
#138125
Merged
+11
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Comment on lines
714
to
718
| let sub = sub.as_str(); | ||
| if explained.contains(sub.as_ref()) { | ||
| continue; | ||
| } | ||
| explained.insert(sub); | ||
| explained.insert(String::from(sub)); |
There was a problem hiding this comment.
If we're optimizing for readability here, I'd probably write this like:
if !explained.insert(sub.as_str()) {
continue;
}There was a problem hiding this comment.
And possibly also change the as_str to call it to_string to make it clear that it returns a String.
compiler-errors
requested changes
Mar 6, 2025
thaliaarchi
force-pushed
the
defer-alloc-printf-suggestion
branch
from
0fedfb8 to
ef6f0d6
Compare
|
It sounds like the readability approach is better, so I'll pivot to that. |
thaliaarchi
force-pushed
the
defer-alloc-printf-suggestion
branch
from
ef6f0d6 to
f8dc132
Compare
thaliaarchi
changed the title
printf suggestions until neededprintf and shell format suggestions
| @@ -13,10 +13,10 @@ pub(crate) mod printf { | |||
| } | |||
|
|
|||
| impl<'a> Substitution<'a> { | |||
| pub(crate) fn as_str(&self) -> &str { | |||
| pub(crate) fn as_string(&self) -> String { | |||
There was a problem hiding this comment.
probably call this to_string, or maybe just implement ToString
thaliaarchi
force-pushed
the
defer-alloc-printf-suggestion
branch
from
f8dc132 to
2458ccd
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Mar 7, 2025
…gestion, r=compiler-errors Simplify `printf` and shell format suggestions Simplify tracking `printf` and shell format suggestions. Although allocations could be deferred until after checking that they aren't already in the map, this style is simpler.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 7, 2025
…kingjubilee Rollup of 12 pull requests Successful merges: - rust-lang#136667 (Revert vita's c_char back to i8) - rust-lang#136780 (std: move stdio to `sys`) - rust-lang#137107 (Override default `Write` methods for cursor-like types) - rust-lang#137363 (compiler: factor Windows x86-32 ABI impl into its own file) - rust-lang#137528 (Windows: Fix error in `fs::rename` on Windows 1607) - rust-lang#137537 (Prevent `rmake.rs` from using unstable features, and fix 3 run-make tests that currently do) - rust-lang#137777 (Specialize `OsString::push` and `OsString as From` for UTF-8) - rust-lang#137832 (Fix crash in BufReader::peek()) - rust-lang#137904 (Improve the generic MIR in the default `PartialOrd::le` and friends) - rust-lang#138115 (Suggest typo fix for static lifetime) - rust-lang#138125 (Simplify `printf` and shell format suggestions) - rust-lang#138129 (Stabilize const_char_classify, const_sockaddr_setters) r? `@ghost` `@rustbot` modify labels: rollup
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Mar 7, 2025
…gestion, r=compiler-errors Simplify `printf` and shell format suggestions Simplify tracking `printf` and shell format suggestions. Although allocations could be deferred until after checking that they aren't already in the map, this style is simpler.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 7, 2025
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#136667 (Revert vita's c_char back to i8) - rust-lang#137107 (Override default `Write` methods for cursor-like types) - rust-lang#137777 (Specialize `OsString::push` and `OsString as From` for UTF-8) - rust-lang#137832 (Fix crash in BufReader::peek()) - rust-lang#137904 (Improve the generic MIR in the default `PartialOrd::le` and friends) - rust-lang#138115 (Suggest typo fix for static lifetime) - rust-lang#138125 (Simplify `printf` and shell format suggestions) - rust-lang#138129 (Stabilize const_char_classify, const_sockaddr_setters) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 7, 2025
Rollup merge of rust-lang#138125 - thaliaarchi:defer-alloc-printf-suggestion, r=compiler-errors Simplify `printf` and shell format suggestions Simplify tracking `printf` and shell format suggestions. Although allocations could be deferred until after checking that they aren't already in the map, this style is simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify tracking
printfand shell format suggestions. Although allocations could be deferred until after checking that they aren't already in the map, this style is simpler.