Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rustdoc): Fixed stability version in rustdoc #137320

Merged
merged 2 commits into from
Feb 26, 2025
Merged

fix(rustdoc): Fixed stability version in rustdoc #137320

merged 2 commits into from
Feb 26, 2025

Conversation

tapanprakasht
Copy link
Contributor

@tapanprakasht tapanprakasht commented Feb 20, 2025 •
edited
Loading

Tries to fix #137141
Fixed by adding checks glob exports

@rustbot
Copy link
Collaborator

rustbot commented Feb 20, 2025

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@fmease fmease added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 20, 2025
@GuillaumeGomez
Copy link
Member

Looks good to me, thanks!

I'll just let @notriddle take a look first before approving.

@notriddle

This comment was marked as duplicate.

Sign in to view
@tapanprakasht tapanprakasht force-pushed the fix-doc-version-stability branch from 2440ec4 to afc89a1 Compare February 23, 2025 17:03
@rustbot rustbot added the T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. label Feb 23, 2025
@tapanprakasht
Copy link
Contributor Author

@GuillaumeGomez or @notriddle I see the PR is approved now. Can you merge the changes if everything okay?

@GuillaumeGomez
Copy link
Member

We were just waiting for CI to pass. Thanks for the fix!

@bors r=notriddle rollup

@bors
Copy link
Contributor

bors commented Feb 25, 2025

📌 Commit afc89a1 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2025
fmease added a commit to fmease/rust that referenced this pull request Feb 26, 2025
@fmease
Rollup merge of rust-lang#137320 - tapanprakasht:fix-doc-version-stab…
775c7cf 
…ility, r=notriddle

fix(rustdoc): Fixed stability version in rustdoc

Tries to fix rust-lang#137141
Fixed by adding checks glob exports
@fmease fmease mentioned this pull request Feb 26, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 26, 2025
@bors
Auto merge of rust-lang#137649 - fmease:rollup-59lpxdh, r=fmease
fa98c79 
Rollup of 13 pull requests

Successful merges:

 - rust-lang#136576 (pass optimization level to llvm-bitcode-linker)
 - rust-lang#137320 (fix(rustdoc): Fixed stability version in rustdoc)
 - rust-lang#137502 (Don't include global asm in `mir_keys`, fix error body synthesis)
 - rust-lang#137529 (remove few unused args)
 - rust-lang#137544 (tests: Add regression test for derive token invalidation (rust-lang#81099))
 - rust-lang#137559 (run some tests on emscripten again)
 - rust-lang#137601 (ssa/mono: deduplicate `type_has_metadata`)
 - rust-lang#137603 (codegen_llvm: avoid `Deref` impls w/ extern type)
 - rust-lang#137604 (trait_sel: resolve vars in host effects)
 - rust-lang#137609 (Complete the list of resources used in rustdoc output)
 - rust-lang#137613 (hir_analysis: skip self type of host effect preds in variances_of)
 - rust-lang#137614 (fix doc in library/core/src/pin.rs)
 - rust-lang#137622 (fix attribute-related ICE when parsing macro on the rhs of a name-value attribute)

r? `@ghost`
`@rustbot` modify labels: rollup
@fmease fmease mentioned this pull request Feb 26, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 26, 2025
@bors
Auto merge of rust-lang#137651 - fmease:rollup-s3s7m6f, r=fmease
2b3cef8 
Rollup of 14 pull requests

Successful merges:

 - rust-lang#136576 (pass optimization level to llvm-bitcode-linker)
 - rust-lang#137154 (Add UTF-8 validation fast paths in `Wtf8Buf`)
 - rust-lang#137311 (Enable `f16` for MIPS)
 - rust-lang#137320 (fix(rustdoc): Fixed stability version in rustdoc)
 - rust-lang#137529 (remove few unused args)
 - rust-lang#137544 (tests: Add regression test for derive token invalidation (rust-lang#81099))
 - rust-lang#137559 (run some tests on emscripten again)
 - rust-lang#137601 (ssa/mono: deduplicate `type_has_metadata`)
 - rust-lang#137603 (codegen_llvm: avoid `Deref` impls w/ extern type)
 - rust-lang#137604 (trait_sel: resolve vars in host effects)
 - rust-lang#137609 (Complete the list of resources used in rustdoc output)
 - rust-lang#137613 (hir_analysis: skip self type of host effect preds in variances_of)
 - rust-lang#137614 (fix doc in library/core/src/pin.rs)
 - rust-lang#137622 (fix attribute-related ICE when parsing macro on the rhs of a name-value attribute)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ef53922 into rust-lang:master Feb 26, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Feb 26, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 26, 2025
@rust-timer
Unrolled build for rust-lang#137320
9d4a699 
Rollup merge of rust-lang#137320 - tapanprakasht:fix-doc-version-stability, r=notriddle

fix(rustdoc): Fixed stability version in rustdoc

Tries to fix rust-lang#137141
Fixed by adding checks glob exports
@yotamofek yotamofek mentioned this pull request Mar 6, 2025
Merged
jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 7, 2025
@jhpratt
Rollup merge of rust-lang#138107 - yotamofek:pr/rustdoc/clippy, r=Gui…
5e04334 
…llaumeGomez

`librustdoc`: clippy fixes

First commit is all machine-generated fixes,
next two are some more lints fixed by hand/misc. cleanups

Inspired by the redundant `.and_then()` added in rust-lang#137320 , and [this comment](rust-lang#138090 (comment))

r? `@GuillaumeGomez`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 7, 2025
@matthiaskrgr
Rollup merge of rust-lang#138107 - yotamofek:pr/rustdoc/clippy, r=Gui…
d207e21 
…llaumeGomez

`librustdoc`: clippy fixes

First commit is all machine-generated fixes,
next two are some more lints fixed by hand/misc. cleanups

Inspired by the redundant `.and_then()` added in rust-lang#137320 , and [this comment](rust-lang#138090 (comment))

r? ``@GuillaumeGomez``
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 7, 2025
@matthiaskrgr
Rollup merge of rust-lang#138107 - yotamofek:pr/rustdoc/clippy, r=Gui…
4b6a22d 
…llaumeGomez

`librustdoc`: clippy fixes

First commit is all machine-generated fixes,
next two are some more lints fixed by hand/misc. cleanups

Inspired by the redundant `.and_then()` added in rust-lang#137320 , and [this comment](rust-lang#138090 (comment))

r? ```@GuillaumeGomez```
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 7, 2025
@rust-timer
Unrolled build for rust-lang#138107
2700d48 
Rollup merge of rust-lang#138107 - yotamofek:pr/rustdoc/clippy, r=GuillaumeGomez

`librustdoc`: clippy fixes

First commit is all machine-generated fixes,
next two are some more lints fixed by hand/misc. cleanups

Inspired by the redundant `.and_then()` added in rust-lang#137320 , and [this comment](rust-lang#138090 (comment))

r? ```@GuillaumeGomez```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yotamofek yotamofek yotamofek requested changes

@notriddle notriddle notriddle approved these changes

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@fmease fmease

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.

Nightly docs of std::task::ready! report wrong stabilization version
7 participants
@tapanprakasht @rustbot @GuillaumeGomez @notriddle @bors @yotamofek @fmease