Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postprocess bootstrap metrics into GitHub job summary #137077

Merged
merged 4 commits into from
Mar 5, 2025
Merged

Postprocess bootstrap metrics into GitHub job summary #137077

merged 4 commits into from
Mar 5, 2025

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Feb 15, 2025 •
edited
Loading

This PR adds a postprocessing step to each CI job that writes the build and test step bootstrap metrics into GitHub job summary. You can see an example result for dist and test jobs here.

r? @ghost

try-job: dist-x86_64-illumos
try-job: x86_64-gnu

@rustbot rustbot added A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 15, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kobzol Kobzol force-pushed the citool-test-metrics branch from 87a498f to 041f639 Compare February 15, 2025 13:40
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kobzol Kobzol force-pushed the citool-test-metrics branch from 041f639 to 8da885b Compare February 15, 2025 14:37
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kobzol Kobzol force-pushed the citool-test-metrics branch from 514c81f to 9b572e6 Compare February 15, 2025 15:28
@bors
Copy link
Contributor

bors commented Feb 16, 2025

☔ The latest upstream changes (presumably #136914) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Feb 19, 2025
@Kobzol Kobzol changed the title [WIP] Postprocess test suite metrics into GitHub summary [WIP] Postprocess bootstrap metrics into GitHub summary Feb 19, 2025
@Kobzol Kobzol force-pushed the citool-test-metrics branch from b1f5c09 to b038dd8 Compare February 19, 2025 15:55
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kobzol Kobzol force-pushed the citool-test-metrics branch 5 times, most recently from 7dca3a4 to 18beca5 Compare February 19, 2025 18:36
@Kobzol
Copy link
Contributor Author

Kobzol commented Feb 19, 2025

@bors try

@bors
Copy link
Contributor

bors commented Feb 19, 2025

⌛ Trying commit 18beca5 with merge 4526f2b...

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 19, 2025
@bors
Auto merge of rust-lang#137077 - Kobzol:citool-test-metrics, r=<try>
4526f2b 
[WIP] Postprocess bootstrap metrics into GitHub summary

Based on rust-lang#136864.

r? `@ghost`
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Feb 19, 2025

☀️ Try build successful - checks-actions
Build commit: 4526f2b (4526f2b73c7249a6ef24ad703afe3f956bd29dd1)

@Kobzol Kobzol marked this pull request as ready for review February 19, 2025 21:58
@rustbot
Copy link
Collaborator

rustbot commented Feb 19, 2025

Some changes occurred in src/tools/cargo

cc @ehuss

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol

Some changes occurred in src/tools/opt-dist

cc @Kobzol

@Kobzol Kobzol changed the title [WIP] Postprocess bootstrap metrics into GitHub summary Postprocess bootstrap metrics into GitHub job summary Mar 2, 2025
@Kobzol Kobzol force-pushed the citool-test-metrics branch from 18beca5 to ca8f5b6 Compare March 2, 2025 17:26
@bors
Copy link
Contributor

bors commented Mar 2, 2025

⌛ Trying commit a16b661 with merge 0f9d006...

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 2, 2025
@bors
Auto merge of rust-lang#137077 - Kobzol:citool-test-metrics, r=<try>
0f9d006 
Postprocess bootstrap metrics into GitHub job summary

This PR adds a postprocessing step to each CI job that writes the build and test step bootstrap metrics into [GitHub job summary](https://github.blog/news-insights/product-news/supercharging-github-actions-with-job-summaries/).

r? `@ghost`

try-job: dist-x86_64-illumos
try-job: x86_64-gnu
@bors
Copy link
Contributor

bors commented Mar 2, 2025

☀️ Try build successful - checks-actions
Build commit: 0f9d006 (0f9d006ce75c1e3977c54fb2c59d1191e2575d70)

@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 3, 2025

r? @marcoieni

marcoieni
marcoieni reviewed Mar 3, 2025
View reviewed changes
Copy link
Member

@marcoieni marcoieni left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to r=me once you addressed this feedback. The most important one is the cargo submodule update, which I'm not sure it's intentional.
The rest of the comments are non-blocking 👍

@Kobzol Kobzol force-pushed the citool-test-metrics branch from a16b661 to 7b53ac7 Compare March 4, 2025 11:32
@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 4, 2025

Applied review changes and cleaned up the commits. Let's see if it still works.

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 4, 2025
@bors
Auto merge of rust-lang#137077 - Kobzol:citool-test-metrics, r=<try>
75076ca 
Postprocess bootstrap metrics into GitHub job summary

This PR adds a postprocessing step to each CI job that writes the build and test step bootstrap metrics into [GitHub job summary](https://github.blog/news-insights/product-news/supercharging-github-actions-with-job-summaries/). You can see an example result for dist and test jobs [here](https://github.com/rust-lang-ci/rust/actions/runs/13619495480).

r? `@ghost`

try-job: dist-x86_64-illumos
try-job: x86_64-gnu
@bors
Copy link
Contributor

bors commented Mar 4, 2025

⌛ Trying commit 7b53ac7 with merge 75076ca...

@bors
Copy link
Contributor

bors commented Mar 4, 2025

☀️ Try build successful - checks-actions
Build commit: 75076ca (75076caad48e2f61625d1608c8087cf80a6cf74d)

@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 4, 2025

Looks good.

@bors r=marcoieni

@bors
Copy link
Contributor

bors commented Mar 4, 2025

📌 Commit 7b53ac7 has been approved by marcoieni

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2025
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Mar 4, 2025
@jieyouxu
Rollup merge of rust-lang#137077 - Kobzol:citool-test-metrics, r=marc…
5813a6e 
…oieni

Postprocess bootstrap metrics into GitHub job summary

This PR adds a postprocessing step to each CI job that writes the build and test step bootstrap metrics into [GitHub job summary](https://github.blog/news-insights/product-news/supercharging-github-actions-with-job-summaries/). You can see an example result for dist and test jobs [here](https://github.com/rust-lang-ci/rust/actions/runs/13619495480).

r? `@ghost`

try-job: dist-x86_64-illumos
try-job: x86_64-gnu
@jieyouxu jieyouxu mentioned this pull request Mar 4, 2025
Closed
@Kobzol Kobzol mentioned this pull request Mar 4, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 4, 2025
@bors
Auto merge of rust-lang#138006 - jieyouxu:rollup-av2viwz, r=jieyouxu
3c361f7 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#134063 (dec2flt: Clean up float parsing modules)
 - rust-lang#136662 (Count char width at most once in `Formatter::pad`)
 - rust-lang#137011 (Promote ohos targets to tier2 with host tools.)
 - rust-lang#137077 (Postprocess bootstrap metrics into GitHub job summary)
 - rust-lang#137327 (Undeprecate env::home_dir)
 - rust-lang#137373 (Compile run-make-support and run-make tests with the bootstrap compiler)
 - rust-lang#137463 ([illumos] attempt to use posix_spawn to spawn processes)
 - rust-lang#137477 (uefi: Add Service Binding Protocol abstraction)
 - rust-lang#137569 (Stablize `string_extend_from_within`)
 - rust-lang#137667 (Add `dist::Gcc` build step)

r? `@ghost`
`@rustbot` modify labels: rollup
@workingjubilee workingjubilee mentioned this pull request Mar 4, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 5, 2025
@bors
Auto merge of rust-lang#138021 - workingjubilee:rollup-brhnycu, r=wor…
ac951d3 
…kingjubilee

Rollup of 6 pull requests

Successful merges:

 - rust-lang#137077 (Postprocess bootstrap metrics into GitHub job summary)
 - rust-lang#137373 (Compile run-make-support and run-make tests with the bootstrap compiler)
 - rust-lang#137634 (Update `compiler-builtins` to 0.1.149)
 - rust-lang#137667 (Add `dist::Gcc` build step)
 - rust-lang#137722 (`librustdoc`: 2024 edition! 🎊)
 - rust-lang#137947 (Do not install rustup on Rust for Linux job)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ee1d019 into rust-lang:master Mar 5, 2025
7 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 5, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 5, 2025
@rust-timer
Unrolled build for rust-lang#137077
757c518 
Rollup merge of rust-lang#137077 - Kobzol:citool-test-metrics, r=marcoieni

Postprocess bootstrap metrics into GitHub job summary

This PR adds a postprocessing step to each CI job that writes the build and test step bootstrap metrics into [GitHub job summary](https://github.blog/news-insights/product-news/supercharging-github-actions-with-job-summaries/). You can see an example result for dist and test jobs [here](https://github.com/rust-lang-ci/rust/actions/runs/13619495480).

r? ``@ghost``

try-job: dist-x86_64-illumos
try-job: x86_64-gnu
@Kobzol Kobzol deleted the citool-test-metrics branch March 5, 2025 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoieni marcoieni marcoieni left review comments

Assignees

@marcoieni marcoieni

Labels
A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Kobzol @rust-log-analyzer @bors @rustbot @marcoieni