add IntoBounds trait
#136904
Merged
add IntoBounds trait
#136904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
4 tasks
pitaj
force-pushed
the
range-into_bounds
branch
from
2047de7 to
40d00c6
Compare
tgross35
reviewed
Feb 12, 2025
library/core/src/ops/range.rs
Outdated
Comment on lines
1028
to
1041
| impl<T> IntoBounds<T> for RangeInclusive<T> { | ||
| fn into_bounds(self) -> (Bound<T>, Bound<T>) { | ||
| ( | ||
| Included(self.start), | ||
| if self.exhausted { | ||
| // When the iterator is exhausted, we usually have start == end, | ||
| // but we want the range to appear empty, containing nothing. | ||
| Excluded(self.end) | ||
| } else { | ||
| Included(self.end) | ||
| }, | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
Wouldn't it be a bit surprising that this provides different results from RangeBounds?
Other than this lgtm, with an optional tiny nit that it may be nice to interleave RangeBounds and IntoBounds impls in this file, as you did for ops/range.rs (just nicer to see implementations for the same type side by side).
There was a problem hiding this comment.
What do you mean? This follows the same pattern in impl<T> RangeBounds<T> for RangeInclusive<T>:
rust/library/core/src/ops/range.rs
Lines 881 to 889 in 34a5ea9
as you did for
ops/range.rs
I assume you mean src/range.rs. I also prefer the organization there, but I felt this better matched the existing style in this file.
There was a problem hiding this comment.
You're right, I was reading a different impl. Case in point regarding the sorting I guess :)
tgross35
approved these changes
Feb 12, 2025
|
@bors r+ |
bors
added
S-waiting-on-bors
fmease
reviewed
Feb 12, 2025
library/core/src/ops/range.rs
Outdated
| /// `IntoBounds` is implemented by Rust’s built-in range types, produced | ||
| /// by range syntax like `..`, `a..`, `..b`, `..=c`, `d..e`, or `f..=g`. | ||
| #[unstable(feature = "range_into_bounds", issue = "136903")] | ||
| pub trait IntoBounds<T: Sized>: RangeBounds<T> { |
There was a problem hiding this comment.
Suggested change
| pub trait IntoBounds<T: Sized>: RangeBounds<T> { | |
| pub trait IntoBounds<T>: RangeBounds<T> { |
<T> means <T: Sized>
bors
added
S-waiting-on-author
for `range_into_bounds` feature, rust-lang#136903
pitaj
force-pushed
the
range-into_bounds
branch
from
40d00c6 to
9c03369
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Feb 14, 2025
add `IntoBounds` trait for `range_into_bounds` feature Tracking issue: rust-lang#136903 ACP: rust-lang/libs-team#538
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 14, 2025
…kingjubilee Rollup of 13 pull requests Successful merges: - rust-lang#135439 (Make `-O` mean `OptLevel::Aggressive`) - rust-lang#136460 (Simplify `rustc_span` `analyze_source_file`) - rust-lang#136642 (Put the alloc unit tests in a separate alloctests package) - rust-lang#136904 (add `IntoBounds` trait) - rust-lang#136908 ([AIX] expect `EINVAL` for `pthread_mutex_destroy`) - rust-lang#136924 (Add profiling of bootstrap commands using Chrome events) - rust-lang#136951 (Use the right binder for rebinding `PolyTraitRef`) - rust-lang#136956 (add vendor directory to .gitignore) - rust-lang#136967 (Use `slice::fill` in `io::Repeat` implementation) - rust-lang#136976 (alloc boxed: docs: use MaybeUninit::write instead of as_mut_ptr) - rust-lang#136981 (ci: switch loongarch jobs to free runners) - rust-lang#136992 (Update backtrace) - rust-lang#136993 ([cg_llvm] Remove dead error message) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 14, 2025
…kingjubilee Rollup of 9 pull requests Successful merges: - rust-lang#135439 (Make `-O` mean `OptLevel::Aggressive`) - rust-lang#136460 (Simplify `rustc_span` `analyze_source_file`) - rust-lang#136904 (add `IntoBounds` trait) - rust-lang#136908 ([AIX] expect `EINVAL` for `pthread_mutex_destroy`) - rust-lang#136924 (Add profiling of bootstrap commands using Chrome events) - rust-lang#136951 (Use the right binder for rebinding `PolyTraitRef`) - rust-lang#136981 (ci: switch loongarch jobs to free runners) - rust-lang#136992 (Update backtrace) - rust-lang#136993 ([cg_llvm] Remove dead error message) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 14, 2025
Rollup merge of rust-lang#136904 - pitaj:range-into_bounds, r=tgross35 add `IntoBounds` trait for `range_into_bounds` feature Tracking issue: rust-lang#136903 ACP: rust-lang/libs-team#538
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for
range_into_boundsfeatureTracking issue: #136903
ACP: rust-lang/libs-team#538