Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow term.progress.when to default #15287

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

Gordon01
Copy link
Contributor

@Gordon01 Gordon01 commented Mar 9, 2025

What does this PR try to resolve?

The config section term.progress contains a collection of options (currently only when and width). If only width is set, Cargo fails with the error: "missing field when." This behavior may be surprising and inconvenient for users who want to set the CARGO_TERM_PROGRESS_WIDTH environment variable.

How should we test and review this PR?

The relevant test, bad_progress_config_missing_when, has been replaced with default_progress_is_auto.

#14615

From #14615 (comment)

I don't recall any particular decisions made regarding bad_progress_config_missing_when. I personally would not object to changing that to allow it to pass. I can't think of a reason it would be required to specify when with width.

@rustbot
Copy link
Collaborator

rustbot commented Mar 9, 2025

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-configuration Area: cargo config files and env vars S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2025
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty reasonable. Thanks!

@weihanglo weihanglo added this pull request to the merge queue Mar 10, 2025
Merged via the queue into rust-lang:master with commit 0dea3cd Mar 10, 2025
21 checks passed
@Gordon01
Copy link
Contributor Author

Amazing!

@Gordon01 Gordon01 deleted the default_for_progress_when branch March 10, 2025 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-configuration Area: cargo config files and env vars S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants