Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust embedded cross #255

Closed
wants to merge 5 commits into from
Closed

Rust embedded cross #255

wants to merge 5 commits into from

Conversation

brainstorm
Copy link
Member

@brainstorm brainstorm commented Sep 8, 2020

Simplify the Cross docker setup even further now that cross-rs/cross#452 got merged upstream :)

This PR removes my transitional custom-build containers in favor of rust-embedded's cross ones.

@coveralls
Copy link

coveralls commented Sep 8, 2020

Pull Request Test Coverage Report for Build 348708859

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.968%

Totals Coverage Status
Change from base Build 345332252: 0.0%
Covered Lines: 10795
Relevant Lines: 11488

💛 - Coveralls

@brainstorm
Copy link
Member Author

brainstorm commented Sep 8, 2020

It seems that the lack of clang/llvm on that cross container is not good for us:

https://github.com/rust-bio/rust-htslib/runs/1084350152?check_suite_focus=true#step:12:4050

OTOH it's intriguing that the same cross command (pulling the same rust-embedded docker images and all):

cross build --release --target x86_64-unknown-linux-musl

Works locally but not on GitHub CI 🤔

Copy link
Contributor

@pmarks pmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice simplification to me, if you can coax the CI to work.

@brainstorm brainstorm self-assigned this Nov 12, 2020
@brainstorm
Copy link
Member Author

The efforts on the MUSL front are not so crucial nowadays given the new developments, see issue #259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants