Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the disableApply server flag to the helm chart #9

Merged
merged 4 commits into from
Jan 13, 2021
Merged

Add the disableApply server flag to the helm chart #9

merged 4 commits into from
Jan 13, 2021

Conversation

gezb
Copy link
Contributor

@gezb gezb commented Oct 25, 2020

This PR adds the option to set the new --disableApply server flag added in runatlantis/atlantis#1230 to the helm chart

lkysow
lkysow previously approved these changes Oct 26, 2020
@lkysow
Copy link
Member

lkysow commented Oct 26, 2020

✖︎ atlantis => (version: "3.12.4", path: "charts/atlantis") > Chart version not ok. Needs a version bump!
Can you bump the chart version?

The other failing test looks like a bug with the test itself.

@gezb
Copy link
Contributor Author

gezb commented Oct 26, 2020

I have pushed a change that updates the Atlantis image version to 0.15.0 and updated the chart version to 3.15

As I assume that the DisableApply changes will push Atlantis version to 0.16.0, should we hold this until 0.16.0? has been released so the flag is valid

@lkysow
Copy link
Member

lkysow commented Oct 26, 2020

Yes we'll need to wait for 0.16.0

@lkysow lkysow merged commit cf3ca2a into runatlantis:main Jan 13, 2021
@gezb gezb deleted the feature/expose_disable_apply_server_flag branch January 13, 2021 18:14
spirosoik pushed a commit to spirosoik/helm-charts that referenced this pull request Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants