Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding flag to toggle wrapped default #820

Merged
merged 1 commit into from
Mar 29, 2020
Merged

Adding flag to toggle wrapped default #820

merged 1 commit into from
Mar 29, 2020

Conversation

mhumeSF
Copy link
Contributor

@mhumeSF mhumeSF commented Oct 31, 2019

Heavy user of Atlantis and ran into a situation where users over-looked the changes of a plan because it had been wrapped. Thought adding a toggle for this behavior would be helpful for those who wanted to opt-out

@mhumeSF
Copy link
Contributor Author

mhumeSF commented Oct 31, 2019

Looks like I'll need to add an updated test to cover the scenario of when the flag is used.

@lkysow
Copy link
Member

lkysow commented Oct 31, 2019

If you run plan a lot on a pull request though the output gets huge. Are you sure you're going to want to set this globally?

@lkysow lkysow added the waiting-on-response Waiting for a response from the user label Nov 7, 2019
@mhumeSF
Copy link
Contributor Author

mhumeSF commented Nov 10, 2019

It would be better if this could be set per repo. Where would I look at setting per repo attributes?

@mhumeSF
Copy link
Contributor Author

mhumeSF commented Nov 11, 2019

I could see the use case where one might want either behavior. To enable globally or per repo. This should be ok to add as well as per repo.

@lkysow lkysow removed the waiting-on-response Waiting for a response from the user label Nov 27, 2019
@mhumeSF
Copy link
Contributor Author

mhumeSF commented Dec 4, 2019

Was able to get this working at the repo level. Adding wrapped: false in atlantis.yaml will toggle wrapped, though pretty certain there is a better way to do this.

Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but I've changed my mind! Let's just add the cli flag for now and see if folks ask for per-repo control.

Let's also change the flag to --fold-long-output.

@lkysow lkysow added the waiting-on-response Waiting for a response from the user label Jan 20, 2020
@mhumeSF
Copy link
Contributor Author

mhumeSF commented Jan 20, 2020

Sure thing, I'll update.

@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #820 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #820      +/-   ##
==========================================
- Coverage   71.74%   71.72%   -0.03%     
==========================================
  Files          65       65              
  Lines        5284     5287       +3     
==========================================
+ Hits         3791     3792       +1     
- Misses       1199     1200       +1     
- Partials      294      295       +1     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a98f93...62d3522. Read the comment docs.

@mhumeSF mhumeSF requested a review from lkysow February 18, 2020 01:10
@mhumeSF

This comment has been minimized.

@mhumeSF
Copy link
Contributor Author

mhumeSF commented Feb 18, 2020

@lkysow I was getting tripped up on testing with flags thinking I had to provide a parameter to bool flags i.e. --fold-long-output false, but this is not the case. I've updated the flag to --disable-folding-long-output because this feels more obvious in what is happening.

@mhumeSF
Copy link
Contributor Author

mhumeSF commented Mar 20, 2020

@lkysow This look good?

@lkysow lkysow removed the waiting-on-response Waiting for a response from the user label Mar 27, 2020
@lkysow lkysow merged commit 35b6a1b into runatlantis:master Mar 29, 2020
@lkysow
Copy link
Member

lkysow commented Mar 29, 2020

Merged in #960. Thanks so much!

@lkysow lkysow added the feature New functionality/enhancement label Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants