-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding flag to toggle wrapped default #820
Conversation
Looks like I'll need to add an updated test to cover the scenario of when the flag is used. |
If you run plan a lot on a pull request though the output gets huge. Are you sure you're going to want to set this globally? |
It would be better if this could be set per repo. Where would I look at setting per repo attributes? |
I could see the use case where one might want either behavior. To enable globally or per repo. This should be ok to add as well as per repo. |
Was able to get this working at the repo level. Adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry but I've changed my mind! Let's just add the cli flag for now and see if folks ask for per-repo control.
Let's also change the flag to --fold-long-output
.
Sure thing, I'll update. |
Codecov Report
@@ Coverage Diff @@
## master #820 +/- ##
==========================================
- Coverage 71.74% 71.72% -0.03%
==========================================
Files 65 65
Lines 5284 5287 +3
==========================================
+ Hits 3791 3792 +1
- Misses 1199 1200 +1
- Partials 294 295 +1 Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
@lkysow I was getting tripped up on testing with flags thinking I had to provide a parameter to bool flags i.e. |
@lkysow This look good? |
Merged in #960. Thanks so much! |
Heavy user of Atlantis and ran into a situation where users over-looked the changes of a plan because it had been wrapped. Thought adding a toggle for this behavior would be helpful for those who wanted to opt-out