Allow specifying config values as environment variables #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added tests - moved AutomaticEnv() call into the init() function of the server flag so it's set when we run the tests. Before it was in main(). - Set SetTypeByDefaultValue to true so boolean flags can be specified as env vars.
lkysow
commented
Mar 20, 2018
|
|
||
| // Configure viper to accept env vars prefixed with ATLANTIS_ that can be | ||
| // used instead of flags. | ||
| s.Viper.SetEnvPrefix("ATLANTIS") |
There was a problem hiding this comment.
@psalaberria002 I moved this in here so that I could test this functionality. I liked it better in main.go but the tests don't run through there so this is a compromise.
lkysow
commented
Mar 20, 2018
| s.Viper.SetEnvPrefix("ATLANTIS") | ||
| s.Viper.SetEnvKeyReplacer(strings.NewReplacer("-", "_")) | ||
| s.Viper.AutomaticEnv() | ||
| s.Viper.SetTypeByDefaultValue(true) |
There was a problem hiding this comment.
Benefits of testing! Without this you can't set a boolean flag as an env var, ex. ATLANTIS_ALLOW_FORK_PRS=true won't work without this.
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
=======================================
Coverage 64.09% 64.09%
=======================================
Files 40 40
Lines 1916 1916
=======================================
Hits 1228 1228
Misses 626 626
Partials 62 62
Continue to review full report at Codecov.
|
|
Awesome |
meringu
pushed a commit
to meringu/atlantis
that referenced
this pull request
May 29, 2023
runatlantis#80) * adding atlantis bootstrap mode to support getting started with atlantis for first time users * removed unwanted confirm variable * vendoring dependencies * more vendoring * more more and more vendoring * comment about bootstrap package * Proposed changes (runatlantis#84) * reviewed all the comments * removing required approval flag since we will default to false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38.
Builds off the great work by @psalaberria002 in #77.