Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape additional comment args. #699

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Escape additional comment args. #699

merged 1 commit into from
Jul 11, 2019

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Jul 11, 2019

Fixes #697.

@lkysow lkysow force-pushed the filter-comment-args branch from a17e84f to b43ba8f Compare July 11, 2019 16:03
@lkysow
Escape additional comment args.
cf59b55 
Remove extra quoting and instead add a backslach to each character in
the extra args before appending it to the command.
ex. atlantis plan -- -var key=val will result in:
  sh -c "atlantis plan \-\v\a\r \k\e\y\=\v\a\l"
Fixes #697.
@lkysow lkysow force-pushed the filter-comment-args branch from b43ba8f to cf59b55 Compare July 11, 2019 16:37
@codecov
Copy link

codecov bot commented Jul 11, 2019 •
edited
Loading

Codecov Report

Merging #699 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #699      +/-   ##
=========================================
+ Coverage   72.37%   72.4%   +0.02%     
=========================================
  Files          61      61              
  Lines        4659    4664       +5     
=========================================
+ Hits         3372    3377       +5     
  Misses       1037    1037              
  Partials      250     250
Impacted Files Coverage Δ
server/events/models/models.go 74.6% <ø> (ø) ⬆️
server/events/runtime/run_step_runner.go 100% <100%> (ø) ⬆️
server/events/comment_parser.go 95.2% <100%> (-0.12%) ⬇️
server/events/runtime/apply_step_runner.go 85.98% <100%> (ø) ⬆️
server/events/runtime/plan_step_runner.go 87.2% <100%> (ø) ⬆️
server/events/project_command_builder.go 83.01% <100%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd02dea...cf59b55. Read the comment docs.

@lkysow lkysow merged commit 9a21eef into master Jul 11, 2019
@lkysow lkysow deleted the filter-comment-args branch July 11, 2019 16:42
@lkysow lkysow mentioned this pull request Jul 11, 2019
Closed
This was referenced Nov 9, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lkysow