Fix require-approval for Bitbucket Cloud. #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bitbucket Cloud changed their APIs to deprecate the username fields. This broke how we were checking for approvals. Rather than propagate the UUID field through the PullRequest model, I use the pull request API response directly while checking approvers.
Codecov Report
@@ Coverage Diff @@
## master #657 +/- ##
=========================================
+ Coverage 72.19% 72.2% +<.01%
=========================================
Files 61 61
Lines 4643 4644 +1
=========================================
+ Hits 3352 3353 +1
Misses 1045 1045
Partials 246 246
Continue to review full report at Codecov.
|
Phylu
reviewed
Jun 3, 2019
| @@ -51,6 +51,7 @@ type PullRequest struct { | |||
| Participants []Participant `json:"participants,omitempty" validate:"required"` | |||
| Links *Links `json:"links,omitempty" validate:"required"` | |||
| State *string `json:"state,omitempty" validate:"required"` | |||
| Author *Author `jsonN:"author,omitempty" validate:"required"` | |||
There was a problem hiding this comment.
@lkysow This jasoN looks strange. However, I am not sure if this will make a problem here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitbucket Cloud changed their APIs to deprecate the username fields.
This broke how we were checking for approvals. Rather than propagate the
UUID field through the PullRequest model, I use the pull request API
response directly while checking approvers.
Fixes #652