Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never use fast-forward merges #585

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Never use fast-forward merges #585

merged 1 commit into from
Apr 10, 2019

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Apr 10, 2019

When using --checkout-strategy merge, we were performing the merge
without the --no-ff flag. This meant that if the branch could be merged
via a fast-forward merge (without a merge commit), then later when we
ran git rev-parse HEAD^2 to determine if the repo was at the right
commit, it would fail.

Now we merge with --no-ff which ensures the commit tree will always look
the same and git rev-parse HEAD^2 will always succeed.

Fixes #584

When using --checkout-strategy merge, we were performing the merge
without the --no-ff flag. This meant that if the branch could be merged
via a fast-forward merge (without a merge commit), then later when we
ran git rev-parse HEAD^2 to determine if the repo was at the right
commit, it would fail.

Now we merge with --no-ff which ensures the commit tree will always look
the same and git rev-parse HEAD^2 will always succeed.
@codecov
Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #585 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #585      +/-   ##
==========================================
- Coverage   72.15%   72.13%   -0.03%     
==========================================
  Files          61       61              
  Lines        4629     4618      -11     
==========================================
- Hits         3340     3331       -9     
+ Misses       1044     1043       -1     
+ Partials      245      244       -1
Impacted Files Coverage Δ
server/events/working_dir.go 74.69% <100%> (ø) ⬆️
cmd/server.go 78.97% <0%> (-0.06%) ⬇️
server/logging/simple_logger.go 0% <0%> (ø) ⬆️
server/events/runtime/run_step_runner.go 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f07d1f...93cd6a5. Read the comment docs.

@lkysow lkysow merged commit 559736c into master Apr 10, 2019
@lkysow lkysow deleted the ff-merges branch April 10, 2019 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant