Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Permission for GitHub app to support mergeable minus apply check #4902

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions runatlantis.io/docs/access-credentials.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@ GitHub App needs these permissions. These are automatically set when a GitHub ap
Since v0.19.7, a new permission for `Administration` has been added. If you have already created a GitHub app, updating Atlantis to v0.19.7 will not automatically add this permission, so you will need to set it manually.

Since v0.22.3, a new permission for `Members` has been added, which is required for features that apply permissions to an organizations team members rather than individual users. Like the `Administration` permission above, updating Atlantis will not automatically add this permission, so if you wish to use features that rely on checking team membership you will need to add this manually.

A new permission for `Actions` has been added, which is required for checking if a pull request is mergbeably bypassing the apply check. Updating Atlantis will not automatically add this permission, so you will need to add this manually.
:::

| Type | Access |
Expand All @@ -108,6 +110,7 @@ Since v0.22.3, a new permission for `Members` has been added, which is required
| Pull requests | Read and write |
| Webhooks | Read and write |
| Members | Read-only |
| Actions | Read-only |

### GitLab

Expand Down
1 change: 1 addition & 0 deletions server/controllers/github_app_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ func (g *GithubAppController) New(w http.ResponseWriter, _ *http.Request) {
"statuses": "write",
"administration": "read",
"members": "read",
"actions": "read",
},
}

Expand Down
Loading