fix: Initialize VCSClient for commandrunner to remove recent server panics #3461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitrocode
previously approved these changes
May 30, 2023
|
@pseudomorph can you describe how you've tested this in the pr body? And/or is there a way to add a unit test or e2e test for this to prevent this from happening in the future? |
nitrocode
changed the title
|
Let me look into an e2e test. |
|
e2e test initializes the server struct directly, not through the NewServer function. Added a unit test instead to ensure that VCSClient is passed in to commandRunner during server initialization. |
jamengual
approved these changes
May 30, 2023
GenPage
approved these changes
May 30, 2023
mtavaresmedeiros
pushed a commit
to mtavaresmedeiros/atlantis
that referenced
this pull request
Jul 3, 2023
…anics (runatlantis#3461) * Initialize VCSClient for commandrunner. * Add test.
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
…anics (runatlantis#3461) * Initialize VCSClient for commandrunner. * Add test.
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
…anics (runatlantis#3461) * Initialize VCSClient for commandrunner. * Add test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
VCSClient was inadvertently removed from the commandrunner instantiation in #3086.
https://github.com/runatlantis/atlantis/pull/3086/files#diff-78f42ba40d0f10b08c73b7e6bb8376f398e249c963cf549e89591d6b6826b9a4L780
This has caused server panics during the course of normal operations.
why
Bugfix.
tests
Added a unit test to ensure that VCSClient is passed to commandRunner during server initialization.
references