Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(atlantis-image): build atlantis image when all packages update #3353

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

GenPage
Copy link
Member

@GenPage GenPage commented Apr 26, 2023

what

Update atlantis-image workflow to build/push the docker image when the following files have updates:

  • go.mod
  • go.sum
  • package.json
  • yarn.lock

Automated tools like dependabot and renovate bump these files only and wouldn't normally trigger the workflow.

why

If there is any version update on any dependency, we should be rebuilding the app and docker image to ensure no conflicts. We were previously only building on go code changes.

tests

  • I have tested my changes by building the image in this PR

references

#3352
#3346
#3330

@GenPage GenPage requested a review from a team as a code owner April 26, 2023 13:30
@GenPage GenPage merged commit b0ebad5 into main Apr 26, 2023
@GenPage GenPage deleted the fix/atlantis-image-build-on-package-update branch April 26, 2023 19:08
@nitrocode nitrocode added this to the v0.24.0 milestone May 8, 2023
mtavaresmedeiros pushed a commit to mtavaresmedeiros/atlantis that referenced this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants