Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note in docs about needing gitlab ee for approval requirements #3290

Closed
wants to merge 2 commits into from

Conversation

jukie
Copy link
Contributor

@jukie jukie commented Apr 4, 2023

what

Adds docs notice for Gitlab Premium requirement to use approval requirements in Atlantis

why

Gitlab Community Edition doesn't support approvals_before_merge so approval requirements in Atlantis won't work.

tests

n/a

references

@jukie jukie requested a review from a team as a code owner April 4, 2023 05:21
@github-actions github-actions bot added the docs Documentation label Apr 4, 2023
@jukie
Copy link
Contributor Author

jukie commented Apr 4, 2023

In addition to the docs update I'd also like to contribute an actual check somewhere in Atlantis and we can log something when an unsupported client is detected and attempts to use this feature. Where should that go?

@jukie jukie closed this Apr 4, 2023
@jamengual
Copy link
Contributor

I do not know if we have a specific place to do that in he code other than the function were we catch the error.

@nitrocode
Copy link
Member

Was this meant to be closed?

@nitrocode
Copy link
Member

Oh i see this was closed due to this comment

#3277 (comment)

@jukie
Copy link
Contributor Author

jukie commented Apr 4, 2023

Yeah it's not needed, I realized after pushing that it's already had there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants