Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: additional renovatebot configurations #2981

Merged
merged 1 commit into from
Jan 15, 2023
Merged

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Jan 13, 2023

what

  • feat: additional renovatebot configurations

why

  • autoclose if no dependencies using dependencydashboardautoclose
  • set pr hourly limit to 1 using prhourlylimit to avoid e2e failures
  • manage yarn dependency updates using lockfilemaintenance
    • current issue dashboard doesn't autodetect the yarn.lock yet
  • enable vulnerability alerts using vulnerabilityalerts
  • remove prConcurrentLimit since it defaults to 10 and we never hit it
  • add a suffix to include the packageFile using the commitMessageSuffix
    • This will add the package file name to the commit and the PR title

tests

  • I have tested my changes by running renovate-config-validator
docker run \
  -v $(pwd)/.github/renovate.json5:/usr/src/app/renovate.json5 \
  --env LOG_LEVEL=debug \
  --rm -it \
  renovate/renovate renovate-config-validator

returns the same thing as the gh pr check

INFO: Config validated successfully

references

@nitrocode nitrocode force-pushed the lockFileMaintenance branch from f42a353 to f188c59 Compare January 14, 2023 21:30
@nitrocode nitrocode marked this pull request as ready for review January 14, 2023 21:30
@nitrocode nitrocode requested a review from a team as a code owner January 14, 2023 21:30
@nitrocode nitrocode changed the title feat: add lockFileMaintenance to renovatebot feat: additional renovatebot configurations Jan 14, 2023
@nitrocode nitrocode force-pushed the lockFileMaintenance branch from 78d212c to 10c3e53 Compare January 14, 2023 22:32
@nitrocode nitrocode force-pushed the lockFileMaintenance branch from 10c3e53 to 39a1931 Compare January 14, 2023 22:34
Copy link
Contributor

@krrrr38 krrrr38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

roger

@nitrocode nitrocode merged commit bfd88b0 into main Jan 15, 2023
@nitrocode nitrocode deleted the lockFileMaintenance branch January 15, 2023 23:34
@nitrocode nitrocode added this to the v0.22.3 milestone Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants