-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): use ~=
and >=
package constraints
#2896
Conversation
latest
base image
latest
base imagelatest
base image
latest
base imagelatest
base image
latest
base imagelatest
base image
latest
base imagelatest
base image and ~=
and >=
package constraints
I'm not a fan of using the I just worry about eroding stability by introducing drifts in packages that would make debugging/tracing errors more difficult. |
If we introduced a new tag, how would Currently |
latest
base image and ~=
and >=
package constraints~=
and >=
package constraints
.github/workflows/atlantis-image.yml
Outdated
# workflow_run: | ||
# workflows: ["atlantis-base"] | ||
# types: [completed] | ||
# branches: [main] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I think it is a good idea, it should be put into the base flow and trigger this workflow upon success completion.
@nitrocode Agreed, there is no different between the two, I guess the point I'm trying to make is re-using tags is not ideal for image caching especially if we want atlantis-base to be more automated. If we release a bad version of atlantis-base, rolling back is also no longer an option. Might I suggest we switch atlantis-base to semvar and have the version bumping be tied in based on commit tags (feat, fix, chore?) I would be happy to hook this up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dependency pin changes LGTM, workflow discussion is out-of-scope for this PR
This is not exactly true because you can tag images with multiple names. If your current |
I think it might be better to merge the base and real images so we do not have to support 2 different images with 2 different workflows. |
@GenPage thanks for the suggestion. Please feel free to propose new changes when you have time. |
using calver is intentional and i think it is better for our case. |
what
~=
and>=
atlantis-base
andatlantis-image
ghawhy
apk
supports~=
apt
only supports>=
atlantis-base
manuallyoptions considered
package install options
=
~=
pins inalpine
and use=
indebian
debian
and only patch updates inalpine
debian
packages are not as stale asalpine
so this is probably fine~=
pins inalpine
and use>=
indebian
atlantis-base options
YYYY-MM-DD
taglatest
checklist
references