Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating diffKeywordRegex to properly handle new test case #2551

Merged
merged 4 commits into from
Nov 4, 2022

Conversation

VladimirSt-XP
Copy link
Contributor

@VladimirSt-XP VladimirSt-XP commented Oct 4, 2022

This PR related to the issue #1899

Details: Updated diffKeywordRegex to properly handle the following use cases related to YAML content in Terraform output:

  • nested inline array, see SomeAuth element
  • changes in simple key-value fields, see operationId element

Testing: Updated existing TestRenderProjectResultsWithEnableDiffMarkdownFormat test case with the following Terraform resource

  # aws_api_gateway_rest_api.rest_api will be updated in-place
  ~ resource "aws_api_gateway_rest_api" "rest_api" {
      ~ body                         = <<-EOT
            openapi: 3.0.0
            security:
              - SomeAuth: []
            paths:
              /someEndpoint:
                get:
          -       operationId: someOperation
          +       operationId: someOperation2
                  responses:
                    204:
                      description: Empty response.
            components:
              schemas:
                SomeEnum:
                  type: string
                  enum:
                    - value1
                    - value2
              securitySchemes:
                SomeAuth:
                  type: apiKey
                  in: header
                  name: Authorization
        EOT
        id                           = "4i5suz5c4l"
        name                         = "test"
        tags                         = {}
        # (9 unchanged attributes hidden)
        # (1 unchanged block hidden)
    }

@jamengual jamengual added waiting-on-response Waiting for a response from the user bug Something isn't working labels Oct 4, 2022
@VladimirSt-XP VladimirSt-XP changed the title New resource in test Updating diffKeywordRegex to properly handle new test case Oct 5, 2022
@VladimirSt-XP VladimirSt-XP marked this pull request as ready for review October 5, 2022 12:30
@VladimirSt-XP VladimirSt-XP requested a review from a team as a code owner October 5, 2022 12:30
@jamengual jamengual added waiting-on-review Waiting for a review from a maintainer and removed waiting-on-response Waiting for a response from the user labels Oct 5, 2022
@VladimirSt-XP
Copy link
Contributor Author

@jamengual let me know please when we can expect the PR to be merged?

@jamengual
Copy link
Contributor

we review from the oldest to the newest PRs, so it is going to take a few weeks, thanks.

@VladimirSt-XP
Copy link
Contributor Author

@jamengual is there any update on this matter?

@jamengual
Copy link
Contributor

@VladimirSt-XP Thanks for the contribution

@jamengual jamengual merged commit 4cc5cf6 into runatlantis:master Nov 4, 2022
@VladimirSt-XP VladimirSt-XP deleted the testing-new-regex branch November 8, 2022 06:56
krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
…is#2551)

* new resource was added to test TestRenderProjectResultsWithEnableDiffMarkdownFormat

* Correct test case

* 1st regex change

* Adding one more pattern to regex

Co-authored-by: dyurovskykh-tivo <[email protected]>
@nitrocode nitrocode added this to the 0.21.0 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working waiting-on-review Waiting for a review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants