Fix AzDo Throttling Timeouts #1715
Conversation
…y-After header. Also added flag to increase timeouts for azdo client. Need both to deal with Azdo throttling
oliverisaac
force-pushed
the
azdo-throttling-timeouts
branch
from
c218198 to
0f19899
Compare
|
bump |
| ADHonorRetryAfter = "azuredevops-honor-retry-after" | ||
| ADTimeoutSeconds = "azuredevops-timeout-seconds" |
There was a problem hiding this comment.
Would be nice to put the word "client" in here to be more specific.
| retryAfterVal := resp.Header.Get("retry-after") | ||
| if retryAfterVal != "" { | ||
| retryAfterSec, err := strconv.Atoi(retryAfterVal) | ||
| if err == nil { | ||
| rt.RetryAfter = time.Duration(retryAfterSec) * time.Second | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we add exponential backoff and jitter here? I know we do this in a lot of other spots but it's not great practice. Risk of thundering herd causing a chain reaction.
Also probably good to call out the risks of using this flag in the docs.
|
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
bump, can we get this back open? @nishkrishnan |
|
@LanceSandino are you going to fix the conflicts? |
|
Ah... sorry after speaking to my colleague this is no longer needed. This can be closed again :) |
|
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Getting errors like the one below due to AzureDevops throttling of api requests:
Took two strategies to help with this:
Both of the options I added default to the present state of things (10 seconds timeout, no retry-after honoring) and will only affect end-users if they explicitly enable those features.