Fixes for pre-workflow-hook #1409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents pre-workflow-hook from locking and cloning the dir if there are no hooks registered
Codecov Report
@@ Coverage Diff @@
## master #1409 +/- ##
==========================================
+ Coverage 69.40% 69.50% +0.10%
==========================================
Files 93 93
Lines 6291 6293 +2
==========================================
+ Hits 4366 4374 +8
+ Misses 1543 1538 -5
+ Partials 382 381 -1
Continue to review full report at Codecov.
|
|
Closing this PR, due to #1418 addressing everything in here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pre-workflow-hooks not logging errors Atlantis doesn't log pre_workflow_hooks #1371
Prevents pre-workflow-hook from locking and cloning the dir if there are no hooks registered. PreWorkflowHook do not respect SkipCloneNoChanges #1342