-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing AutoMerge issue with Azure DevOps #1289
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1289 +/- ##
==========================================
- Coverage 70.05% 70.00% -0.05%
==========================================
Files 74 74
Lines 5540 5545 +5
==========================================
+ Hits 3881 3882 +1
- Misses 1303 1305 +2
- Partials 356 358 +2
Continue to review full report at Codecov.
|
Hi @lkysow Can You advise please why the ci/circleci: test is pending? Do we need to do any further steps in order to get our PR merged? |
Hi @lkysow , Could you please take a look? We would like to continue with other enhancements for Azure DevOps which for this is a prerequisite. Thanks! |
Hi @tapaszto, it seems your branch has drifted behind master a bit. If you could either merge or rebase to resolve the conflicts I will be happy to get this merged in. |
Hi @acastle, I performed a merge and resolved the conflicts, can You approve the PR please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Hi @acastle , Thanks for approving the PR, but I'm not sure what to do now, can You advise please? Will it be automatically merged or do I need to perform any further steps? |
Hi @tapaszto, our typical process is to get two sets of eyes from the maintainer group on non trivial PRs before they are merged. Once another maintainer gives an ok we will get this merged and released. There is nothing further you need to do at this point. I can't comment on when exactly you can expect these changes to be in a release but it will likely be after the holidays as a number of the maintainers are enjoying some well deserved time off 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR is fixing the #1152 Azure DevOps related issue by getting the Azure DevOps user Id on the fly and putting it into azuredevops.GitPullRequest.AutoCompleteSetBy.