Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump terraform-config-inspect to fix #1153 #1163

Closed
wants to merge 1 commit into from

Conversation

joerx
Copy link

@joerx joerx commented Aug 20, 2020

As reported in #1153 Atlantis fails to determine the Terraform version if an exact version is specified and custom providers are used.

This is due to the currently used version of terraform-config-inspect not supporting the new syntax for required_provider blocks introduced in Terraform 0.13.0. See #1153 (comment)

This PR updates the dependency to the latest version, which fixes the issue.

@joerx joerx changed the title Bump terraform-config-inspect to issue 1153 Bump terraform-config-inspect to fix #1153 Aug 20, 2020
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #1163 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1163      +/-   ##
==========================================
- Coverage   70.73%   70.71%   -0.03%     
==========================================
  Files          71       71              
  Lines        5973     5975       +2     
==========================================
  Hits         4225     4225              
- Misses       1396     1398       +2     
  Partials      352      352              
Impacted Files Coverage Δ
server/events/project_command_builder.go 80.07% <0.00%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2335eb...afd4e40. Read the comment docs.

@andrewjeffree
Copy link

@lkysow Sorry to poke but can you look at this one when you get a chance.

@lkysow
Copy link
Member

lkysow commented Aug 27, 2020

Thanks for the PR! Unfortunately with large dependency updates like this I need to do them myself so I don't need to audit all the changed files. I've done that in #1171 which will be merged shortly.

@lkysow lkysow closed this Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants