Document terraform bin download location

[mwarkentin]

When upgrading from an older version that stored it in .atlantis this confused us for a little while.

[codecov]

Codecov Report

Merging #1018 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1018   +/-   ##
=======================================
  Coverage   71.96%   71.96%           
=======================================
  Files          65       65           
  Lines        5429     5429           
=======================================
  Hits         3907     3907           
  Misses       1215     1215           
  Partials      307      307           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d318eb...83b3c22. Read the comment docs.

[lkysow]

It only downloads the --default-tf-version binary there. The binaries set via terraform config or atlantis.yaml get downloaded to $HOME/.atlantis/bin/terraform${VERSION}

[mwarkentin]

@lkysow hm, we are running atlantis in fargate, so it makes it a bit tricky to get in and poke around, but after upgrading to atlantis 0.12, we had to make the following change to our custom workflows to make it work for both TF 0.11 and 0.12 binaries:

Do you have a pointer to where the code is for the binary downloads - just trying to square what you're saying with what we were seeing.

[mwarkentin]

@lkysow I think it's because of this: https://github.com/runatlantis/atlantis/blob/master/Dockerfile#L9-L16

We're using 0.11.14 and 0.12.24 so both of those are picked up by default in /usr/local/bin it looks like..

[mwarkentin]

Also, I just noticed this in the changelog for 0.9:

• The directory where Atlantis downloads Terraform binaries is now in the PATH of custom workflows (Append terraform binary dir to PATH when running custom commands #678)

So maybe our problem goes away if we just drop the absolute path from the workflow

[lkysow]

So maybe our problem goes away if we just drop the absolute path from the workflow

yes that should work now since we made that change.

There's 3 sources for tf downloads:

1. Docker image puts them in /usr/local/bin
2. --default-tf-version puts it in ~/.atlantis/bin
3. atlantis.yaml or terraform_version config on individual projects puts in in ~/.atlantis/bin

[lkysow]

I'm going to close for now after the discussion.