feat(express): support Express v5 #13064
Conversation
|
|
Hi @rossipedia, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
MichaelDeBoey
changed the title
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
rossipedia
force-pushed
the
patch-1
branch
2 times, most recently
from
4ab5e78 to
4464d60
Compare
|
@rossipedia It seems like something went wrong when rebasing onto |
`express@5` is out, and is mostly compatible with `express@4` (see [the migration guide](https://expressjs.com/en/guide/migrating-5.html)). At least for React Router usage the differences should be immaterial. This would allow users to integrate React Router into their existing `express@5` apps, or use `express@5` as a hosting server, without having to fiddle with `--legacy-peer-deps` or similar.
|
@MichaelDeBoey I think that should do it, does it look OK now? |
|
Thank you! |
…d-route-typegen * upstream/dev: (65 commits) Generate types for `virtual:react-router/server-build` (remix-run#13152) Add support for client context and middleware (unstable) (remix-run#12941) Add playground for `vite-plugin-cloudflare` (remix-run#13151) do not typegen params for layout routes with a corresponding index (remix-run#13131) (remix-run#13140) Fix types for `loaderData` and `actionData` that contain `Record`s (remix-run#13139) chore: format chore(dev): remove unused dependencies (remix-run#13134) Remove unused Vite file system watcher (remix-run#13133) Remove stale changesets cherry-picked into release-next for 7.2.0 Fix custom SSR build input with `serverBundles` (remix-run#13107) Skip resource route flow in dev mode when SPA mode is enabled (remix-run#13113) chore: format Add integration test for `vite-plugin-cloudflare` (remix-run#13099) Fix custom client `build.rollupOptions.output.entryFileNames` (remix-run#13098) Detect lazy route discovery manifest version mismatches and trigger reloads (remix-run#13061) Fix critical CSS with custom `Vite.DevEnvironment` (remix-run#13066) Fix usage of `prerender` option with `serverBundles` (remix-run#13082) Fix support for custom `build.assetsDir` (remix-run#13077) Add changeset for remix-run#13064 Only import the root route when SSRing SPA mode's index.html (remix-run#13023) ...
|
🤖 Hello there, We just published version Thanks! |
express@5is out, and is mostly compatible withexpress@4(see the migration guide). At least for React Router usage the differences should be immaterial.This would allow users to integrate React Router into their existing
express@5apps, or useexpress@5as a hosting server, without having to fiddle with--legacy-peer-depsor similar.