Support optimizing ssr environment dependencies
#13007
Conversation
🦋 Changeset detectedLatest commit: df22b53 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hi @jamesopstad, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
| @@ -1166,6 +1169,7 @@ export const reactRouterVitePlugin: ReactRouterVitePlugin = () => { | |||
|
|
|||
| viteChildCompiler = await vite.createServer({ | |||
| ...viteUserConfig, | |||
| cacheDir: "node_modules/.vite-child-compiler", | |||
There was a problem hiding this comment.
This is to ensure that the child compiler cannot overwrite the default cache directory.
| { | ||
| name: "react-router:override-optimize-deps", | ||
| config(userConfig) { | ||
| if ( | ||
| ctx.reactRouterConfig.future.unstable_viteEnvironmentApi && | ||
| userConfig.environments | ||
| ) { | ||
| for (const environmentName of Object.keys( | ||
| userConfig.environments | ||
| )) { | ||
| userConfig.environments[environmentName].optimizeDeps = { | ||
| noDiscovery: true, | ||
| }; | ||
| } | ||
| } else { | ||
| userConfig.optimizeDeps = { noDiscovery: true }; | ||
| } | ||
| }, | ||
| }, |
There was a problem hiding this comment.
This plugin prevents unnecessary dependency optimization in the child compiler.
markdalgleish
changed the title
ssr environment dependencies
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
This adds support for optimizing dependencies in server environments by setting
optimizeDeps.entriesandoptimizeDeps.includeif the environment hasoptimizeDeps.noDiscoveryset tofalse. Server environments default tonoDiscovery: trueso this will only affect environments that opt in. This is a requirement of the Cloudflare Vite plugin, which relies on dependency pre-bundling. As the scanner does not include virtual modules, theentriesare required for discovery.