POC optimization for matchRoutes

[brophdawg11]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: dd53c69

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
react-router	Patch
@remix-run/router	Patch
react-router-dom	Patch
react-router-dom-v5-compat	Patch
react-router-native	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[mattkubej]

LGTM, tested locally and observed total time improvements to matchRoutes/matchRoutesImpl by about 40% on navigation

[github-actions]

🤖 Hello there,

We just published version 6.28.3-pre-v6.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[jwallet]

well looks like this fix broke all navigation on initial load :/

[DiRover]

I have a problem with navigation now, when login and logout in my app

[brophdawg11]

Could you elaborate? Please open a github issue with a reproduction so we can look into it

[jwallet]

search params are ignored now?, actually I think it comes from this MR #12899 using diff between @[email protected]

https://github.com/remix-run/react-router/blame/cc8b8cebe241c1464424e1a66d1f3e3bfa5bdd4d/packages/router/__tests__/lazy-discovery-test.ts#L2439

so the navigation works inside the app, but if i copy paste an url to another tab the router does not find the valid path/route and shows our default 404, some of these route use queryparams, my-page?view=tab1

[brophdawg11]

Can you provide a reproduction? Route matching only considers the pathname so I'm unsure what issue you would be running into not exposing search params to patchRoutesOnNavigation