Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): add RHSSO sub claim resolvers to auth e2e tests #2451

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

JessicaJHee
Copy link
Member

@JessicaJHee JessicaJHee commented Feb 25, 2025

Description

Adds e2e tests for the oidcSubClaimMatchingKeycloakUserId OIDC auth resolver

  • sets this resolver as the default one for RHSSO auth e2e tests

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci openshift-ci bot requested review from gustavolira and psrna February 25, 2025 20:34
@JessicaJHee
Copy link
Member Author

@albarbaro I did notice that on the first run of RHBK - remove a user from RHDH it fails on this on the first run:

expect(loginSucceded).toContain("Login successful");

But passes on the retry. Any ideas on why this might be?

@JessicaJHee JessicaJHee changed the title add RHSSO sub claim resolvers to auth e2e tests chore: add RHSSO sub claim resolvers to auth e2e tests Feb 25, 2025
@JessicaJHee JessicaJHee changed the title chore: add RHSSO sub claim resolvers to auth e2e tests chore(e2e): add RHSSO sub claim resolvers to auth e2e tests Feb 25, 2025
@JessicaJHee
Copy link
Member Author

/retest

@albarbaro
Copy link
Member

@albarbaro I did notice that on the first run of RHBK - remove a user from RHDH it fails on this on the first run:

expect(loginSucceded).toContain("Login successful");

But passes on the retry. Any ideas on why this might be?

I did notice the same recently but I wasn't able to figure it out yet. My guess is this is due to a sync issue after the previous test cases are run, since on retry the users are re-created and the sync happens again, but I haven't verified it yet.

@JessicaJHee
Copy link
Member Author

/retest

@JessicaJHee JessicaJHee force-pushed the e2e-oidc-sub-resolver branch from 2f52982 to 0e829df Compare March 3, 2025 15:56
@JessicaJHee JessicaJHee force-pushed the e2e-oidc-sub-resolver branch from 0e829df to d3e7de9 Compare March 3, 2025 18:52
Copy link
Contributor

github-actions bot commented Mar 3, 2025

@albarbaro
Copy link
Member

/lgtm
/approve

@JessicaJHee
Copy link
Member Author

/cherry-pick release-1.5

@openshift-cherrypick-robot
Copy link
Contributor

@JessicaJHee: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@JessicaJHee
Copy link
Member Author

/retest

@openshift-ci openshift-ci bot removed the lgtm label Mar 4, 2025
@kim-tsao
Copy link
Member

kim-tsao commented Mar 4, 2025

/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Mar 5, 2025
@albarbaro
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 5, 2025
Copy link

openshift-ci bot commented Mar 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: albarbaro, kim-tsao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Mar 5, 2025
Copy link

openshift-ci bot commented Mar 5, 2025

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Mar 7, 2025

@JessicaJHee: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests a32f80b link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants