-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(e2e): add RHSSO sub claim resolvers to auth e2e tests #2451
base: main
Are you sure you want to change the base?
chore(e2e): add RHSSO sub claim resolvers to auth e2e tests #2451
Conversation
@albarbaro I did notice that on the first run of
But passes on the retry. Any ideas on why this might be? |
/retest |
I did notice the same recently but I wasn't able to figure it out yet. My guess is this is due to a sync issue after the previous test cases are run, since on retry the users are re-created and the sync happens again, but I haven't verified it yet. |
/retest |
2f52982
to
0e829df
Compare
Signed-off-by: Jessica He <[email protected]>
0e829df
to
d3e7de9
Compare
The image is available at: |
/lgtm |
/cherry-pick release-1.5 |
@JessicaJHee: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: albarbaro, kim-tsao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
@JessicaJHee: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Adds e2e tests for the
oidcSubClaimMatchingKeycloakUserId
OIDC auth resolverWhich issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer