-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(marketplace): Add marketplace providers to add entities into the catalog #483
base: main
Are you sure you want to change the base?
feat(marketplace): Add marketplace providers to add entities into the catalog #483
Conversation
Changed Packages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice!
4dc6035
to
b25c681
Compare
Ran |
b25c681
to
8583a38
Compare
8583a38
to
0958110
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @karthikjeeyar, +1 from my side.
Just one thing I personally would do different: instead of finding a parent "marketplace" workspace, I would make the path configurable from the app-config.yaml. Like this:
catalog:
providers:
extensions:
local-provider:
globs:
- /marketplace/catalog/entities/**/*.yaml
But I'm 100% fine with this for 1.5 and we can make it more configurable in the future.
Thanks a lot for picking this up!!
Hey, I just made a Pull Request!
This PR adds three new marketplace providers to add entities into the catalog. The providers reads the plugins, package and collection entity metadata from RHDH image and adds to the catalog.
Screenshots:
Unit tests
✔️ Checklist