Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(marketplace): Add marketplace providers to add entities into the catalog #483

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

karthikjeeyar
Copy link
Contributor

@karthikjeeyar karthikjeeyar commented Mar 7, 2025

Hey, I just made a Pull Request!

This PR adds three new marketplace providers to add entities into the catalog. The providers reads the plugins, package and collection entity metadata from RHDH image and adds to the catalog.

        catalog.addEntityProvider(new MarketplacePackageProvider(taskRunner));
        catalog.addEntityProvider(new MarketplacePluginProvider(taskRunner));
        catalog.addEntityProvider(new MarketplaceCollectionProvider(taskRunner));

Screenshots:

image

Unit tests

image

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@rhdh-gh-app
Copy link

rhdh-gh-app bot commented Mar 7, 2025

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-catalog-backend-module-marketplace workspaces/marketplace/plugins/catalog-backend-module-marketplace patch v0.2.0

Copy link
Member

@gashcrumb gashcrumb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@karthikjeeyar karthikjeeyar force-pushed the marketplace-provider branch from 4dc6035 to b25c681 Compare March 7, 2025 19:40
@karthikjeeyar
Copy link
Contributor Author

Ran yarn dedupe and pushed the changes.

@karthikjeeyar karthikjeeyar force-pushed the marketplace-provider branch from b25c681 to 8583a38 Compare March 7, 2025 20:19
@karthikjeeyar karthikjeeyar force-pushed the marketplace-provider branch from 8583a38 to 0958110 Compare March 7, 2025 20:29
Copy link

sonarqubecloud bot commented Mar 8, 2025

Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @karthikjeeyar, +1 from my side.

Just one thing I personally would do different: instead of finding a parent "marketplace" workspace, I would make the path configurable from the app-config.yaml. Like this:

catalog:
  providers:
    extensions:
      local-provider:
        globs:
          - /marketplace/catalog/entities/**/*.yaml

See also https://backstage.io/docs/features/software-catalog/external-integrations/#follow-up-config-defined-schedule

But I'm 100% fine with this for 1.5 and we can make it more configurable in the future.

Thanks a lot for picking this up!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants