RHIDP-5514: Floating action button #925
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-925/ @ 03/07/25 09:56:12 |
pabel-rh
added
Peer review needed 📖
do-no-merge/review-in-progress 👀
Technical review needed 🔩
|
/lgtm |
pabel-rh
added
Technical review done ⛅
christoph-jerolimov
suggested changes
Feb 17, 2025
There was a problem hiding this comment.
Hi @pabel-rh, hi @debsmita1,
thanks for this. It's great to have it. But one small and one medium request:
I personally would not use the term onClick. It's really technical and then customers can not use this.
And I don't think we should document the "static way" to use the global floating action button. From my understanding, that's not an option for RHDH customers.
For engineers and the upstream community, we should provide a good plugin README and maybe a (tech) docs folder in the plugin.
...ng-a-floating-action-button/proc-configuring-floating-action-button-as-a-dynamic-plugin.adoc
Outdated
Show resolved
Hide resolved
...ng-a-floating-action-button/proc-configuring-floating-action-button-as-a-dynamic-plugin.adoc
Outdated
Show resolved
Hide resolved
assemblies/assembly-install-and-configuring-a-floating-action-button.adoc
Outdated
Show resolved
Hide resolved
...ing-a-floating-action-button/proc-configuring-floating-action-button-as-a-static-plugin.adoc
Outdated
Show resolved
Hide resolved
...iguring-a-floating-action-button/proc-install-floating-action-button-as-a-static-plugin.adoc
Outdated
Show resolved
Hide resolved
pabel-rh
added
Technical review needed 🔩
|
@pabel-rh can you please paste the deep preview link(s) in the PR description so they are easy to find and review? :) |
linfraze
reviewed
Feb 18, 2025
assemblies/assembly-install-and-configuring-a-floating-action-button.adoc
Outdated
Show resolved
Hide resolved
assemblies/assembly-install-and-configuring-a-floating-action-button.adoc
Outdated
Show resolved
Hide resolved
...ng-a-floating-action-button/proc-configuring-floating-action-button-as-a-dynamic-plugin.adoc
Outdated
Show resolved
Hide resolved
...ng-a-floating-action-button/proc-configuring-floating-action-button-as-a-dynamic-plugin.adoc
Outdated
Show resolved
Hide resolved
...ng-a-floating-action-button/proc-configuring-floating-action-button-as-a-dynamic-plugin.adoc
Outdated
Show resolved
Hide resolved
...guring-a-floating-action-button/proc-install-floating-action-button-as-a-dynamic-plugin.adoc
Outdated
Show resolved
Hide resolved
...ng-a-floating-action-button/proc-configuring-floating-action-button-as-a-dynamic-plugin.adoc
Outdated
Show resolved
Hide resolved
debsmita1
requested changes
Feb 20, 2025
assemblies/assembly-install-and-configuring-a-floating-action-button.adoc
Outdated
Show resolved
Hide resolved
assemblies/assembly-install-and-configuring-a-floating-action-button.adoc
Outdated
Show resolved
Hide resolved
...ng-a-floating-action-button/proc-configuring-floating-action-button-as-a-dynamic-plugin.adoc
Outdated
Show resolved
Hide resolved
hmanwani-rh
reviewed
Feb 26, 2025
There was a problem hiding this comment.
@pabel-rh Nice work! I've added a few comments for your consideration. Please take a look and let me know if you've any questions.
...ng-a-floating-action-button/proc-configuring-floating-action-button-as-a-dynamic-plugin.adoc
Outdated
Show resolved
Hide resolved
...ng-a-floating-action-button/proc-configuring-floating-action-button-as-a-dynamic-plugin.adoc
Show resolved
Hide resolved
...ng-a-floating-action-button/proc-configuring-floating-action-button-as-a-dynamic-plugin.adoc
Outdated
Show resolved
Hide resolved
...ng-a-floating-action-button/proc-configuring-floating-action-button-as-a-dynamic-plugin.adoc
Outdated
Show resolved
Hide resolved
...ng-a-floating-action-button/proc-configuring-floating-action-button-as-a-dynamic-plugin.adoc
Outdated
Show resolved
Hide resolved
...ng-a-floating-action-button/proc-configuring-floating-action-button-as-a-dynamic-plugin.adoc
Outdated
Show resolved
Hide resolved
...ng-a-floating-action-button/proc-configuring-floating-action-button-as-a-dynamic-plugin.adoc
Outdated
Show resolved
Hide resolved
...ng-a-floating-action-button/proc-configuring-floating-action-button-as-a-dynamic-plugin.adoc
Outdated
Show resolved
Hide resolved
...ng-a-floating-action-button/proc-configuring-floating-action-button-as-a-dynamic-plugin.adoc
Show resolved
Hide resolved
debsmita1
reviewed
Mar 7, 2025
...ng-a-floating-action-button/proc-configuring-floating-action-button-as-a-dynamic-plugin.adoc
Outdated
Show resolved
Hide resolved
debsmita1
reviewed
Mar 7, 2025
|
|
||
| .Procedure | ||
|
|
||
| . Add the `app-config-dynamic.yaml` content into the dynamic plugins configuration file `app.config-local.yaml`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s):
main, 1.5
Add the relevant labels to the Pull Request.
Issue:
RHIDP-5514
Preview link:
https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-925/customizing/#configuring-a-floating-action-button