Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename reactjs-jsx-ppx to reason-react-ppx #732

Merged
merged 10 commits into from
Jun 14, 2023
Merged

Rename reactjs-jsx-ppx to reason-react-ppx #732

merged 10 commits into from
Jun 14, 2023

Conversation

davesnx
Copy link
Member

@davesnx davesnx commented Jun 12, 2023 •
edited
Loading

Renamed the ppx to make it more clear what it is. I didn't update the file-name due to some further PRs touching this and not causing conflicts.

@anmonteiro updated flake.nix but I'm not able to test it locally, could you make sure it's alright?

@anmonteiro
Copy link
Member

Should this be called ppx_react_jsx? I think it's more common to prefix ppx library names with ppx_* rather than suffix?

@davesnx
Copy link
Member Author

davesnx commented Jun 13, 2023

Happy to follow the convention. I remember discussing the name previously to something like reason-react.ppx but we wanted a different package. Does ppx_reason_react sound good?

@anmonteiro
Copy link
Member

Right, we wanted a different package so that we'd be able to install the ppx separately from the library.

I think ppx_reason_react makes sense, since the PPX is specific to this library.

@davesnx
Merge branch 'main' of github.com:/reasonml/reason-react into Rename-ppx
e37611f 
* 'main' of github.com:/reasonml/reason-react:
  feat: react/jsx-runtime (#714)
  chore: update flakes / add ocamlformat (#731)
  opam-ci: load cache before setup-ocaml (#727)
davesnx added 6 commits June 13, 2023 10:47
@davesnx
Merge branch 'main' of github.com:/reasonml/reason-react into Rename-ppx
ab2ab2b 
* 'main' of github.com:/reasonml/reason-react:
  Post v0.11 release cleanup (#733)
@davesnx
Merge branch 'main' of github.com:/reasonml/reason-react into Rename-ppx
2c96f97 
* 'main' of github.com:/reasonml/reason-react:
  Add suppressHydrationWarning (#721)
@davesnx
Visually separate in steps react.t
9a20460
@davesnx
Update test to not print display from dune
901c032
@davesnx
Merge branch 'main' of github.com:/reasonml/reason-react into Rename-ppx
9764a85 
* 'main' of github.com:/reasonml/reason-react:
  Add changelog entries for #714 and #721 (#735)
@davesnx
Add CHANGES entry
49e864b
@davesnx davesnx merged commit 9e70d75 into main Jun 14, 2023
@davesnx davesnx deleted the Rename-ppx branch June 14, 2023 09:52
davesnx added a commit to davesnx/opam-repository that referenced this pull request Sep 13, 2023
@davesnx
[new release] reason-react and reason-react-ppx (0.12.0)
d7c1691 
CHANGES:

* Migrate the reason-react PPX and library to the [new React JSX
transform](https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html)
  (@anmonteiro in [reasonml/reason-react#714](reasonml/reason-react#714))
* Add `suppressHydrationWarning` to supported props (@davesnx in
[reasonml/reason-react#721](reasonml/reason-react#721))
* Rename `reactjs-jsx-ppx` to `reason-react-ppx` ([@davesnx in reasonml/reason-react#732](reasonml/reason-react#732))
* Fix locations for lower and uppercase components so that merlin / editor
  integration can get type defs on hover ([@jchavarri in reasonml/reason-react#748](reasonml/reason-react#748))
* Refine types for `key` attributes ([@anmonteiro in reasonml/reason-react#750](reasonml/reason-react#750))
* Bump React depext to v17-18 reasonml/reason-react#777 ([@jchavarri in reasonml/reason-react#777](https://github.com/reasonml/reason-react/pull/777/files))
* Make optional props optional properly
 ([@davesnx in reasonml/reason-react#776](reasonml/reason-react@0a98c07))
davesnx added a commit to davesnx/opam-repository that referenced this pull request Sep 13, 2023
@davesnx
[new release] reason-react and reason-react-ppx (0.12.0)
e397e69 
CHANGES:

* Migrate the reason-react PPX and library to the [new React JSX
transform](https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html)
  (@anmonteiro in [reasonml/reason-react#714](reasonml/reason-react#714))
* Add `suppressHydrationWarning` to supported props (@davesnx in
[reasonml/reason-react#721](reasonml/reason-react#721))
* Rename `reactjs-jsx-ppx` to `reason-react-ppx` ([@davesnx in reasonml/reason-react#732](reasonml/reason-react#732))
* Fix locations for lower and uppercase components so that merlin / editor
  integration can get type defs on hover ([@jchavarri in reasonml/reason-react#748](reasonml/reason-react#748))
* Refine types for `key` attributes ([@anmonteiro in reasonml/reason-react#750](reasonml/reason-react#750))
* Bump React depext to v17-18 reasonml/reason-react#777 ([@jchavarri in reasonml/reason-react#777](https://github.com/reasonml/reason-react/pull/777/files))
* Make optional props optional properly
 ([@davesnx in reasonml/reason-react#776](reasonml/reason-react@0a98c07))
@davesnx davesnx mentioned this pull request Sep 13, 2023
Merged
davesnx added a commit to davesnx/opam-repository that referenced this pull request Sep 13, 2023
@davesnx
[new release] reason-react and reason-react-ppx (0.12.0)
bdcf1ce 
CHANGES:

* Migrate the reason-react PPX and library to the [new React JSX
transform](https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html)
  (@anmonteiro in [reasonml/reason-react#714](reasonml/reason-react#714))
* Add `suppressHydrationWarning` to supported props (@davesnx in
[reasonml/reason-react#721](reasonml/reason-react#721))
* Rename `reactjs-jsx-ppx` to `reason-react-ppx` ([@davesnx in reasonml/reason-react#732](reasonml/reason-react#732))
* Fix locations for lower and uppercase components so that merlin / editor
  integration can get type defs on hover ([@jchavarri in reasonml/reason-react#748](reasonml/reason-react#748))
* Refine types for `key` attributes ([@anmonteiro in reasonml/reason-react#750](reasonml/reason-react#750))
* Bump React depext to v17-18 reasonml/reason-react#777 ([@jchavarri in reasonml/reason-react#777](https://github.com/reasonml/reason-react/pull/777/files))
* Make optional props optional properly
 ([@davesnx in reasonml/reason-react#776](reasonml/reason-react@0a98c07))
nberth pushed a commit to nberth/opam-repository that referenced this pull request Jun 18, 2024
@davesnx @nberth
[new release] reason-react and reason-react-ppx (0.12.0)
6380a93 
CHANGES:

* Migrate the reason-react PPX and library to the [new React JSX
transform](https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html)
  (@anmonteiro in [reasonml/reason-react#714](reasonml/reason-react#714))
* Add `suppressHydrationWarning` to supported props (@davesnx in
[reasonml/reason-react#721](reasonml/reason-react#721))
* Rename `reactjs-jsx-ppx` to `reason-react-ppx` ([@davesnx in reasonml/reason-react#732](reasonml/reason-react#732))
* Fix locations for lower and uppercase components so that merlin / editor
  integration can get type defs on hover ([@jchavarri in reasonml/reason-react#748](reasonml/reason-react#748))
* Refine types for `key` attributes ([@anmonteiro in reasonml/reason-react#750](reasonml/reason-react#750))
* Bump React depext to v17-18 reasonml/reason-react#777 ([@jchavarri in reasonml/reason-react#777](https://github.com/reasonml/reason-react/pull/777/files))
* Make optional props optional properly
 ([@davesnx in reasonml/reason-react#776](reasonml/reason-react@0a98c07))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davesnx @anmonteiro