Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with special characters in Kafka Streams Dev UI #46599

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

dcotfr
Copy link
Contributor

@dcotfr dcotfr commented Mar 3, 2025

Sanitizes the IDs by replacing the use of the short form of ID (see 1. below) with double-quoted IDs (see 3. below), cleaned up of the inner quotes, during the Graphviz script generation phase.

This solves both 29411 & 37691 issues.

Root cause
Current Graphviz script generation use short form of ID (1), not supporting '.' and/or regex patterns
According to Graphviz documentation, an ID is one of the following:

1. Any string of alphabetic ([a-zA-Z\200-\377]) characters, underscores ('_') or digits([0-9]), not beginning with a digit;
2. a numeral [-]?(.[0-9]⁺ | [0-9]⁺(.[0-9]*)? );
3. any double-quoted string ("...") possibly containing escaped quotes (\")¹;
4. an HTML string (<...>).

Double-quoted form (3) supports both '.' and regex patterns (after inner quotes cleaning).

Fixes #29411
Fixes #37691

@gsmet gsmet changed the title Resolves 29411 & 37691 issues Fix issues with special characters in Kafka Streams Dev UI Mar 3, 2025
@gsmet
Copy link
Member

gsmet commented Mar 3, 2025

@ozangunalp could you also have a look at this one? It looks like something we would want for 3.19.

@gsmet gsmet requested a review from ozangunalp March 3, 2025 22:52
Copy link

quarkus-bot bot commented Mar 3, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 7b7b8d9.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit f33a5e5 into quarkusio:main Mar 4, 2025
26 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.21 - main milestone Mar 4, 2025
@gsmet gsmet modified the milestones: 3.21 - main, 3.19.2 Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants