-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix return type for MariaDB PAM substitution #46276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jerboaa how come it wasn't detected before? My experience is that GraalVM is usually checking things are consistent?
Ah I see, this is probably related to https://github.com/quarkusio/quarkus/pull/46221/files . But I'm surprised the GraalVM version used by @yrodiere didn't fail. |
@gsmet The change that introduced the return type check is in GraalVM for JDK 22 and better. See oracle/graal#7340 I'm guessing #46221 only got checked with GraalVM for JDK 21 which doesn't do the checking. We should be able to see those issues quickly on the mandrel side, though (at least for quarkus main). |
Status for workflow
|
Closes #46274
Tested with 25+8.1 GraalVM Community:
Also with a 23.1 (JDK 21) mandrel build. Works fine.
@zakkak @gsmet PTAL. Thanks!