Qute: add some more built-in string extensions

[mkouba]

• str:concat, str:join, str:builder, str:eval

[github-actions]

🙈 The PR is closed and the preview is expired.

[ia3andy]

Thansk!

[quarkus-bot]

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit aae8420.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit aae8420.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

[gbourant]

I think that eval is implemented but not used in StringTemplateExtensions.java class. Sorry for commenting on a closed one :)

[mkouba]

I think that eval is implemented but not used in StringTemplateExtensions.java class. Sorry for commenting on a closed one :)

Indeed, it has to be implemented as a NamespaceResolver: https://github.com/quarkusio/quarkus/blob/main/independent-projects/qute/core/src/main/java/io/quarkus/qute/StrEvalNamespaceResolver.java

But from user POV it's kind of a "string extension" ;-).

[gbourant]

Is this a bug? I'm confused. When I use {str:eval('Hello')} in my Qute template I get {str:eval('Hello')}: No matching namespace [str] extension. The other goodies (str:concat, str:join, str:builder) you have added are working fine.

[mkouba]

Is this a bug? I'm confused. When I use {str:eval('Hello')} in my Qute template I get {str:eval('Hello')}: No matching namespace [str] extension. The other goodies (str:concat, str:join, str:builder) you have added are working fine.

That's weird. This namespace resolver was also added in this PR. Could you share a sample of your app that would demonstrate the problem? What does the stack trace look like?

[gbourant]

This is the error that I get. Check the reproducer here

Caused by: io.quarkus.qute.TemplateException: Found incorrect expressions (1):
	[1] root.html:19:1 - {str:eval('Hello')}: No matching namespace [str] extension method found

	at io.quarkus.qute.deployment.QuteProcessor.processTemplateErrors(QuteProcessor.java:272)
	at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:733)
	at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
	at io.quarkus.builder.BuildContext.run(BuildContext.java:255)
	at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
	at org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2675)
	at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2654)
	at org.jboss.threads.EnhancedQueueExecutor.runThreadBody(EnhancedQueueExecutor.java:1627)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1594)
	at java.base/java.lang.Thread.run(Thread.java:1583)
	at org.jboss.threads.JBossThread.run(JBossThread.java:499)
	Suppressed: io.quarkus.qute.TemplateException: root.html:19:1 - {str:eval('Hello')}: No matching namespace [str] extension method found
		at io.quarkus.qute.TemplateException$Builder.build(TemplateException.java:169)
		at io.quarkus.qute.deployment.QuteProcessor.processTemplateErrors(QuteProcessor.java:237)
		... 10 more

[mkouba]

Ok, so it's the build-time validation failure. Maybe we don't have a test for this. I'll take a look. Thanks for the report!

[mkouba]

@gbourant You're absolutely right, we do fail the build if there's at least one template extension method for a namespace (str:) and no matching extension method is found during validation. This assumption is incorrect and we should just ignore the relevant expression. I'll send a follow-up PR.

A workaround exists, just add the following dummy template extension method - it will be never used but tricks the validation:

@TemplateExtension(namespace = "str", matchName = "eval", priority = Integer.MIN_VALUE)
static String dummy(String template) {
   throw new UnsupportedOperationException();
}