Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config converter loading issue when arrays are used #46171

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Feb 10, 2025

We essentially use Class.forName to load the class instead of the ClassLoader directly, as the former knows how to deal with arrays

@geoand
Copy link
Contributor Author

geoand commented Feb 10, 2025

This should also have a test, but I don't know where you want it to be @radcortez

@radcortez
Copy link
Member

We can add a test in integration-tests/test-extension/extension. Thanks!

We essentially use Class.forName to load the class instead of the
ClassLoader directly, as the former knows how to deal with arrays

Fixes: quarkusio#46170
@geoand
Copy link
Contributor Author

geoand commented Feb 10, 2025

Thanks, PR updated

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 10, 2025
Copy link

quarkus-bot bot commented Feb 10, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 909bf16.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/opentelemetry/deployment

io.quarkus.opentelemetry.deployment.logs.LoggingFrameworkTest.testLog4jLogging - History

  • Expected log to have body <ValueString{Log4j Logging message}> but was <ValueString{RESTEASY004687: Closing a class org.jboss.resteasy.client.jaxrs.engines.ManualClosingApacheHttpClient43Engine$CleanupAction instance for you. Please close clients yourself.}> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: Expected log to have body <ValueString{Log4j Logging message}> but was <ValueString{RESTEASY004687: Closing a class org.jboss.resteasy.client.jaxrs.engines.ManualClosingApacheHttpClient43Engine$CleanupAction instance for you. Please close clients yourself.}>
	at io.quarkus.opentelemetry.deployment.logs.LoggingFrameworkTest.testLog4jLogging(LoggingFrameworkTest.java:95)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:513)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:427)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

@geoand geoand merged commit 35ed171 into quarkusio:main Feb 10, 2025
55 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 10, 2025
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Feb 10, 2025
@geoand geoand deleted the #46170 branch February 10, 2025 15:27
@gsmet gsmet modified the milestones: 3.19 - main, 3.18.3 Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration custom converters fail on primitive type arrays since Quarkus v3.18
3 participants