Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-existing value "OPTIONAL", fix typo #46113

Merged
merged 1 commit into from
Feb 9, 2025
Merged

Conversation

gefloh
Copy link
Contributor

@gefloh gefloh commented Feb 5, 2025

Sorry, should have fixed this with the last PR at the very same location but I only realized it now. Now the whole CI has to run again. :-/

This value OPTIONAL does not exist in the underlying Vertx Mail Client. It's almost funny that it's also incorrectly documented in io.vertx.ext.mail.LoginOption (where the docs were copied from) and in io.vertx.ext.mail.MailConfig.

Additionally, I wonder why they called the other option NONE considering its meaning, but that's probably their secret.

Fixed a tiny typo that was also copied over from Vertx Mail Client, but then it is correct at least here in Quarkus.

@geoand geoand requested a review from cescoffier February 6, 2025 08:09
@gefloh
Copy link
Contributor Author

gefloh commented Feb 6, 2025

Upstream fix vert-x3/vertx-mail-client#226

@gefloh
Copy link
Contributor Author

gefloh commented Feb 7, 2025

@gsmet It's a no-brainer. ;-)

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and sorry for the delay!

Copy link

quarkus-bot bot commented Feb 8, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit d674851.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

You can consult the Develocity build scans.

Copy link

quarkus-bot bot commented Feb 8, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit d674851.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link

github-actions bot commented Feb 8, 2025

🎊 PR Preview 5c1f904 has been successfully built and deployed to https://quarkus-pr-main-46113-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@gsmet gsmet merged commit 2748a88 into quarkusio:main Feb 9, 2025
22 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Feb 9, 2025
@gsmet gsmet modified the milestones: 3.19 - main, 3.18.3 Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants