Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute simple JUnit tests and @QuarkusComponentTest first #46046

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Feb 3, 2025

I was hoping to constrain JUnit tests and @QuarkusComponentTests but @QuarkusComponentTest is in another artifact so this will have to do.

Fixes #46035.

Note that you can still break things if you specify another priority but that's how it is :).

This comment has been minimized.

@geoand geoand force-pushed the execute-nonquarkustests-first branch from 3eec982 to b538fbd Compare February 6, 2025 08:29
@geoand
Copy link
Contributor

geoand commented Feb 6, 2025

Rebased on main since the errors were weird and I want to see if they were actually caused by the PR

This comment has been minimized.

@gsmet
Copy link
Member Author

gsmet commented Feb 7, 2025

Yeah, I need to check what's going on. Will see if I can get it before we branch 3.19 but I'm not sure about that.

I was hoping to constrain JUnit tests and @QuarkusComponentTests but
@QuarkusComponentTest is in another artifact so this will have to do.

Related to quarkusio#46035.

Note that you can still break things if you specify another priority but
that's how it is :).
The ITs were run as part of the Surefire execution and apparently
something is leaking from them.
It wasn't an issue before because they were executed at the end of the
run but they were executed first with the new orderer given they are
not annotated with a Quarkus test annotation.
@gsmet gsmet force-pushed the execute-nonquarkustests-first branch from 569390e to 1abb1b9 Compare February 10, 2025 18:07
@gsmet
Copy link
Member Author

gsmet commented Feb 10, 2025

@geoand so there's something leaking somewhere but the test infra of the module was all borked. I isolated the ITs in a proper Failsafe run instead of grouping them with the Surefire tests and things are fine now.

The problem was caused by the leaking tests now being executed first as they are ITs and not having any sort of Quarkus test annotation.

At some point, we should probably try to figure out what the leak is but given Holly's ongoing work, I'm not sure it's worth it.

@geoand
Copy link
Contributor

geoand commented Feb 10, 2025

At some point, we should probably try to figure out what the leak is but given Holly's ongoing work, I'm not sure it's worth it.

Right. At best it could be redundant, at worst it could cause more merge conflicts

Copy link

quarkus-bot bot commented Feb 10, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 1abb1b9.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit 42648ac into quarkusio:main Feb 11, 2025
54 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Feb 11, 2025
@gsmet gsmet modified the milestones: 3.19 - main, 3.18.3 Feb 11, 2025
@holly-cummins
Copy link
Contributor

I've had a quick peek at this and #46035. I think:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QuarkusTest TestProfile pollutes environment of QuarkusComponentTest
3 participants