-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Execute simple JUnit tests and @QuarkusComponentTest first #46046
Conversation
This comment has been minimized.
This comment has been minimized.
3eec982
to
b538fbd
Compare
Rebased on main since the errors were weird and I want to see if they were actually caused by the PR |
This comment has been minimized.
This comment has been minimized.
Yeah, I need to check what's going on. Will see if I can get it before we branch 3.19 but I'm not sure about that. |
b538fbd
to
dbb0e19
Compare
I was hoping to constrain JUnit tests and @QuarkusComponentTests but @QuarkusComponentTest is in another artifact so this will have to do. Related to quarkusio#46035. Note that you can still break things if you specify another priority but that's how it is :).
The ITs were run as part of the Surefire execution and apparently something is leaking from them. It wasn't an issue before because they were executed at the end of the run but they were executed first with the new orderer given they are not annotated with a Quarkus test annotation.
569390e
to
1abb1b9
Compare
@geoand so there's something leaking somewhere but the test infra of the module was all borked. I isolated the ITs in a proper Failsafe run instead of grouping them with the Surefire tests and things are fine now. The problem was caused by the leaking tests now being executed first as they are ITs and not having any sort of Quarkus test annotation. At some point, we should probably try to figure out what the leak is but given Holly's ongoing work, I'm not sure it's worth it. |
Right. At best it could be redundant, at worst it could cause more merge conflicts |
Status for workflow
|
I've had a quick peek at this and #46035. I think:
|
I was hoping to constrain JUnit tests and @QuarkusComponentTests but @QuarkusComponentTest is in another artifact so this will have to do.
Fixes #46035.
Note that you can still break things if you specify another priority but that's how it is :).