Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Oracle Driver to 23.6.0.24.10 and switch to ojdbc17 #46029

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

suppen-kaspar
Copy link
Contributor

@suppen-kaspar suppen-kaspar commented Feb 1, 2025

Update to new oracle driver version 23.6.0.24.10.
With this version ojdbc17 should be used as this is the "official" certified one for JDK17-21 and Jakarta APIs
see: https://www.oracle.com/de/database/technologies/appdev/jdbc-downloads.html

Closes #46028

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/jdbc Issues related to the JDBC extensions labels Feb 1, 2025
@suppen-kaspar suppen-kaspar force-pushed the feat/update-to-ojdbc17 branch from 237e445 to 13ee5b5 Compare February 1, 2025 09:58

This comment has been minimized.

Copy link

github-actions bot commented Feb 1, 2025

🎊 PR Preview 0d2bdfb has been successfully built and deployed to https://quarkus-pr-main-46029-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

This comment has been minimized.

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The change makes sense.

FTR I'm planning the same change in Hibernate ORM's test suite: https://hibernate.atlassian.net/browse/HHH-19094
EDIT: Turns out it was already being worked on, see hibernate/hibernate-orm#9310 , https://hibernate.atlassian.net/browse/HHH-18877

The build fails, but failures seem unrelated... I'll try rebasing on main.

@yrodiere yrodiere force-pushed the feat/update-to-ojdbc17 branch from 13ee5b5 to ab4e4e0 Compare February 3, 2025 08:35
@yrodiere yrodiere added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 3, 2025
Copy link

quarkus-bot bot commented Feb 3, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit ab4e4e0.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Feb 3, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit ab4e4e0.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/grpc-hibernate

com.example.grpc.hibernate.BlockingRawTest.shouldAdd - History

  • Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at com.example.grpc.hibernate.BlockingRawTestBase.shouldAdd(BlockingRawTestBase.java:59)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

⚙️ Native Tests - HTTP

📦 integration-tests/rest-client-reactive

io.quarkus.it.rest.client.BasicTestIT.shouldCreateClientSpans - History

  • expected: <1> but was: <2> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <1> but was: <2>
	at io.quarkus.it.rest.client.BasicTest.shouldCreateClientSpans(BasicTest.java:216)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:789)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

⚙️ Native Tests - Security2

📦 integration-tests/oidc-client-wiremock

io.quarkus.it.keycloak.OidcClientInGraalITCase.testGetAccessTokenWithConfiguredExpiresIn - History

  • expected: <true> but was: <false> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at io.quarkus.it.keycloak.OidcClientTest.testGetAccessTokenWithConfiguredExpiresIn(OidcClientTest.java:68)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:789)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@gsmet gsmet merged commit 69c66a9 into quarkusio:main Feb 3, 2025
54 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 3, 2025
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Feb 3, 2025
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Feb 3, 2025
@gsmet
Copy link
Member

gsmet commented Feb 3, 2025

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/jdbc Issues related to the JDBC extensions kind/enhancement New feature or request triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Oracle Driver to 23.6.0.24.10 and use ojdbc17 instead
4 participants