Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MetricsTest reliability #45960

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

brunobat
Copy link
Contributor

No description provided.

@brunobat brunobat requested a review from gsmet January 29, 2025 17:51
Copy link

quarkus-bot bot commented Jan 29, 2025

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

This message is automatically generated by a bot.

Copy link

quarkus-bot bot commented Jan 29, 2025

/cc @ebullient (metrics), @jmartisk (metrics)

await().atMost(5, SECONDS).until(() -> getSpans().size() == 2);
await().atMost(10, SECONDS).until(() -> {
List<Map<String, Object>> spans = getSpans();
System.out.println("spans size " + spans.size());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you should display the content of spans instead? That might be more helpful if we have to debug it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of... Most likely it was failing because it was also reading a span from a previous test, throwing the count to 3.
I just want make sure, if it happens again.

Copy link

quarkus-bot bot commented Jan 29, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c34a2de.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit 3e7485f into quarkusio:main Jan 30, 2025
20 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Jan 30, 2025
@holly-cummins
Copy link
Contributor

I've just re-implemented this fix. I was about to do a PR to submit it to main. I rebased before my PR, and discovered you'd done the same fix at around the same time! Doh!

So yes, +1 for this fix from me. Especially with this test order, the lack of a wait in the reset caused quite consistent failures.

2025-01-27T13:47:46.7866097Z [INFO] Running io.quarkus.it.opentelemetry.EagerAuthEndUserEnabledTest
2025-01-27T13:47:56.7538432Z [INFO] Running io.quarkus.it.opentelemetry.LazyAuthEndUserEnabledTest
2025-01-27T13:48:04.7432007Z [INFO] Running io.quarkus.it.opentelemetry.StaticResourceTest
2025-01-27T13:48:06.4511240Z [INFO] Running io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest
2025-01-27T13:48:07.3800407Z [INFO] Running io.quarkus.it.opentelemetry.TracingTest
2025-01-27T13:48:20.0560604Z [INFO] Running io.quarkus.it.opentelemetry.LoggingResourceTest
2025-01-27T13:48:22.7209597Z [INFO] Running io.quarkus.it.opentelemetry.tck.SpanBeanTest
2025-01-27T13:48:22.7279496Z [INFO] Running io.quarkus.it.opentelemetry.MetricsTest

I have a minor variant of the fix that reduces the chattiness in the 'success' case, so I'll pop that in a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants