-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve MetricsTest reliability #45960
Conversation
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
/cc @ebullient (metrics), @jmartisk (metrics) |
await().atMost(5, SECONDS).until(() -> getSpans().size() == 2); | ||
await().atMost(10, SECONDS).until(() -> { | ||
List<Map<String, Object>> spans = getSpans(); | ||
System.out.println("spans size " + spans.size()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you should display the content of spans
instead? That might be more helpful if we have to debug it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of... Most likely it was failing because it was also reading a span from a previous test, throwing the count to 3.
I just want make sure, if it happens again.
Status for workflow
|
I've just re-implemented this fix. I was about to do a PR to submit it to main. I rebased before my PR, and discovered you'd done the same fix at around the same time! Doh! So yes, +1 for this fix from me. Especially with this test order, the lack of a wait in the reset caused quite consistent failures.
I have a minor variant of the fix that reduces the chattiness in the 'success' case, so I'll pop that in a PR. |
No description provided.