Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix static file path decoding in vertx-http #45835

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Fix static file path decoding in vertx-http #45835

merged 1 commit into from
Jan 27, 2025

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented Jan 23, 2025

Solving #45775 for the Quarkus static file handling.

@ia3andy ia3andy changed the title Fix static file decoding in vertx-http Fix static file path decoding in vertx-http Jan 23, 2025
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@ia3andy ia3andy force-pushed the fix-decoding-static branch from 53095ae to f2eab9f Compare January 24, 2025 07:04
@ia3andy ia3andy requested a review from FroMage January 24, 2025 07:04
@ia3andy ia3andy force-pushed the fix-decoding-static branch from f2eab9f to f106711 Compare January 24, 2025 10:23
@ia3andy ia3andy force-pushed the fix-decoding-static branch from f106711 to 7899c9d Compare January 24, 2025 10:23
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jan 27, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 7899c9d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

FroMage
FroMage approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ia3andy ia3andy merged commit ad6c51d into quarkusio:main Jan 27, 2025
53 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Jan 27, 2025
@ia3andy ia3andy deleted the fix-decoding-static branch January 27, 2025 14:32
@gsmet gsmet modified the milestones: 3.19 - main, 3.18.1 Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FroMage FroMage FroMage approved these changes

Assignees
No one assigned
Labels
area/vertx triage/flaky-test
Projects
None yet
Milestone
3.18.1
Development

Successfully merging this pull request may close these issues.
3 participants
@ia3andy @FroMage @gsmet