Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Tidy ignore array in tool.ruff.lint #3069

Merged
merged 16 commits into from
Jan 23, 2025
Merged

Conversation

j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented Jan 22, 2025

No description provided.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.36%. Comparing base (f1b471b) to head (34a3216).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3069   +/-   ##
=======================================
  Coverage   96.36%   96.36%           
=======================================
  Files          52       52           
  Lines        8769     8769           
  Branches     1596     1596           
=======================================
  Hits         8450     8450           
  Misses        191      191           
  Partials      128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j-t-1
Copy link
Contributor Author

j-t-1 commented Jan 22, 2025

If this change is okay, please sort the ignore array before commit...

@stefan6419846
Copy link
Collaborator

If this change is okay, please sort the ignore array before commit...

I do not really understand this comment. Is there anything to do from my side before merging?

@j-t-1
Copy link
Contributor Author

j-t-1 commented Jan 22, 2025

I have put every lint rule and associated comment on one line. If this PR is okay, then could you sort them before committing? Or if they look ok, I can sort them.

@stefan6419846
Copy link
Collaborator

Feel free to sort them yourself - I try to keep edits on other PRs as small as possible.

@stefan6419846
Copy link
Collaborator

Are you able to document the previously undocumented exceptions (and the ones currently documented without any real value) with at least the content of the rule as well while we are already at it?

@j-t-1
Copy link
Contributor Author

j-t-1 commented Jan 22, 2025

Are you able to document the previously undocumented exceptions (and the ones currently documented without any real value) with at least the content of the rule as well while we are already at it?

Have completed and improved some of the set. If OK commit this, and will return to further improving it when I can.

@j-t-1
Copy link
Contributor Author

j-t-1 commented Jan 23, 2025

@stefan6419846 this is now done.

@stefan6419846 stefan6419846 merged commit eec079d into py-pdf:main Jan 23, 2025
16 checks passed
@j-t-1 j-t-1 deleted the ignore branch January 23, 2025 10:12
blushingpenguin pushed a commit to blushingpenguin/pypdf that referenced this pull request Jan 24, 2025
stefan6419846 added a commit that referenced this pull request Jan 26, 2025
## What's new

### Deprecations (DEP)
- Deprecate with replacement CCITParameters (#3019) by @j-t-1
- Correct deprecation of interiour_color (#2947) by @j-t-1

### New Features (ENH)
- Support alternative (U)F names for embedded file retrieval (#3072) by @stefan6419846
- Adding support for reading .metadata.keywords (#2939) by @Lucas-C

### Bug Fixes (BUG)
- Handle further Tf operators in text extraction layout mode (#3073) by @blushingpenguin
- Ensure `add_metadata` can deal with `_info = None` (#3040) by @xmo-odoo
- Handle IndirectObject in CCITTFaxDecode filter (#2965) by @stefan6419846
- Handle chained colorspace for inline images when no filter is set (#3008) by @stefan6419846
- Avoid extracting inline images twice and dropping other operators (#3002) by @stefan6419846
- Fixed reference of value with `str.__new__` in TextStringObject (#2952) by @thomas-forte
- Handle indirect objects in font width calculations (#2967) by @nsw42
- Title sometimes is bytes and not str (#2930) by @reformy
- Fix undefined variable for text extraction (regression) (#2934) by @stefan6419846
- Don't close stream passed to PdfWriter.write() (#2909) by @alexaryn

### Robustness (ROB)
- Handle zero height fonts when extracting text (#3075) by @blushingpenguin
- Deal with content streams not containing streams (#3005) by @stefan6419846
- Gracefully handle some text operators when the operands are missing (#3006) by @stefan6419846
- Fall back to non-Adobe Ascii85 format for missing end markers (#3007) by @stefan6419846
- Ignore odd-length strings when processing cmap lines (#3009) by @stefan6419846
- Skip annotation destination being NullObject in PdfWriter (#2964) by @stefan6419846
- Skip destination page being None in PdfWriter (#2963) by @dxsooo
- Fix infinite loop case when reading null objects within an Array by @jakep-allenai
- Fixing infinite loop in ArrayObject read_from_stream (#2928) by @jakep-allenai

### Documentation (DOC)
- Add note about default line colors (#3014) by @stefan6419846

### Developer Experience (DEV)
- Remove ignoring Ruff rule PGH004 (#3071) by @j-t-1
- Tidy ignore array in tool.ruff.lint (#3069) by @j-t-1
- Move Windows CI to Python 3.13 (#3003) by @stefan6419846
- Move to Ubuntu 22.04 (#3004) by @stefan6419846

### Maintenance (MAINT)
- Fix formatting of warning message and include exception message (#3076) by @stefan6419846
- Narrow return type for `ContentStream.operations` (#2941) by @kmurphy4

### Testing (TST)
- Fix image similarity for upcoming Ubuntu 24.04 (#3039) by @stefan6419846
- Replace broken Apache Tika Corpora urls (#3041) by @stefan6419846

### Code Style (STY)
- Add form feed to WHITESPACES (#3054) by @j-t-1
- Lots of small internal changes by @j-t-1

[Full Changelog](5.1.0...5.2.0)

Signed-off-by: stefan6419846 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants