Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests TestPrintProbeSuccess and TestPrintProbeFail #237

Merged
merged 3 commits into from
Oct 6, 2024

Conversation

basil-gray
Copy link
Contributor

Describe your changes

Added two new tests to check the format and color of printProbeSuccess and printProbeFail

Issue ticket number and link

Closes #232

@pouriyajamshidi
Copy link
Owner

Hi @basil-gray

The tests are failing. Could you please have a look?

@basil-gray
Copy link
Contributor Author

Hi @pouriyajamshidi

I changed the tests to not account for colors. Could you run the workflow again?

@pouriyajamshidi
Copy link
Owner

Hi @basil-gray

Thanks! the tests are passing now. Will have a close look and have this merged in. Appreciate your collaboration.

Copy link
Owner

@pouriyajamshidi pouriyajamshidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@pouriyajamshidi pouriyajamshidi merged commit 03b196f into pouriyajamshidi:master Oct 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add tests for outputting information to stdout
2 participants