Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI issue #231

Closed

Conversation

Ilhan-Personal
Copy link
Contributor

No description provided.

@Ilhan-Personal
Copy link
Contributor Author

Hey @pouriyajamshidi I was expecting Codefactor to throw the same CI error I faced in #225 did something change?

@Ilhan-Personal Ilhan-Personal marked this pull request as ready for review September 1, 2024 08:18
@pouriyajamshidi
Copy link
Owner

Hey @SYSHIL

No, nothing has changed code-base wise.

Although, I am not sure if empty commits cause the codeFactor to check the entire code or not.

One surprising thing is that the CI is running without approval. In actual PRs, I have to always click run for the CI to trigger.

@pouriyajamshidi
Copy link
Owner

yep, I can confirm codeQL triggers on code changes! Best part is it does only check the parts you change and not the overall code-base :)

@Ilhan-Personal
Copy link
Contributor Author

Heyy @pouriyajamshidi sorry I missed this message from you, had a busy month...thanks for the knowledge share!

Copy link

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 7 days if no further activity occurs.
Let's figure out how to push this issue forward together by commenting here.

Thank you for your contribution!

@github-actions github-actions bot added the stale label Nov 18, 2024
Copy link

This pull request has been automatically closed because it has not had recent activity or follow ups.

@github-actions github-actions bot closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants