Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor step report for column values based validation #49

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

rich-iannone
Copy link
Member

This PR refactors the display of step reports involving column value checks. Previously, row numbers in problem rows did not reflect the row numbers of the extracted rows' original dataset. This has been fixed. Also, highlighting of None/Null values in the extract table is deactivated for the step report (since this distracts from the highlighting of the column checked).

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@rich-iannone rich-iannone merged commit 4166afa into main Feb 5, 2025
4 checks passed
@rich-iannone rich-iannone deleted the fix-preview-refactor branch February 5, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants