Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Integrate column expressions in certain validation methods with Ibis source tables #3

Merged
merged 23 commits into from
Dec 17, 2024

Conversation

rich-iannone
Copy link
Member

This PR is analogous to #2 , except that the column expressions in select validation methods are made to work with Ibis backend tables (could be of type Parquet, DuckDB, MySQL, etc.).

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 98.28571% with 3 lines in your changes missing coverage. Please review.

Project coverage is 99.64%. Comparing base (cdb53c8) to head (fa2f9cc).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
pointblank/validate.py 75.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
- Coverage   99.84%   99.64%   -0.20%     
==========================================
  Files          10       10              
  Lines        1272     1417     +145     
==========================================
+ Hits         1270     1412     +142     
- Misses          2        5       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rich-iannone rich-iannone marked this pull request as ready for review December 17, 2024 05:44
@rich-iannone rich-iannone merged commit fadab15 into main Dec 17, 2024
4 of 6 checks passed
@rich-iannone rich-iannone deleted the feat-ibis-col-expr-integration branch December 17, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant