Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow definition of multiple dtypes per column in Schema to facilitate multiple attempts at dtype matching #17

Merged
merged 6 commits into from
Jan 2, 2025

Conversation

rich-iannone
Copy link
Member

This PR enhances the Schema class so that multiple column data types can be declared. This doesn't affect previous tests or potential workflows since a dtype can be provided as a string value (previously) or list of strings (new here). Many new tests added to verify the new functionality.

We also fix an argument typo across multiple files (the full_match_dtypes= arg) and update/improve the clarity of the schema documentation.

Typographical error fixes:

  • Corrected the spelling of full_match_dtypes= in pointblank/_interrogation.py, pointblank/schema.py, and pointblank/validate.py files.

Documentation improvements:

  • Enhanced the schema documentation in pointblank/schema.py to clarify the format for specifying column names and data types.

Regex pattern refinements:

  • Updated regex patterns in pointblank/validate.py to use [0-9] instead of \d for better readability and consistency (also to avoid a deprecation warning)

@rich-iannone rich-iannone merged commit 5edd9cb into main Jan 2, 2025
4 checks passed
@rich-iannone rich-iannone deleted the feat-schema-check-multiple-dtypes branch January 2, 2025 19:11
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.83%. Comparing base (3669361) to head (9d5d89f).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage   99.82%   99.83%           
=======================================
  Files          11       11           
  Lines        1760     1784   +24     
=======================================
+ Hits         1757     1781   +24     
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant