Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added logic to auto detect system level proxy #1665

Merged
merged 8 commits into from
Jul 24, 2024
Merged

Added logic to auto detect system level proxy #1665

merged 8 commits into from
Jul 24, 2024

Conversation

chinmay-browserstack
Copy link
Contributor

@chinmay-browserstack chinmay-browserstack commented Jul 18, 2024 •
edited
Loading

  • Detect system level proxy and log a warning message
  • added option useSystemProxy to use proxy which was detected

@chinmay-browserstack chinmay-browserstack requested a review from a team as a code owner July 18, 2024 21:46
@chinmay-browserstack chinmay-browserstack marked this pull request as draft July 18, 2024 21:48
@chinmay-browserstack chinmay-browserstack marked this pull request as ready for review July 19, 2024 13:37
@chinmay-browserstack chinmay-browserstack merged commit ed3868d into master Jul 24, 2024
36 checks passed
@chinmay-browserstack chinmay-browserstack deleted the auto_detect_system_proxy branch July 24, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninadbstack ninadbstack ninadbstack approved these changes

@rishigupta1599 rishigupta1599 rishigupta1599 approved these changes

@prklm10 prklm10 Awaiting requested review from prklm10 prklm10 is a code owner automatically assigned from percy/percy-product-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chinmay-browserstack @ninadbstack @rishigupta1599