Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add translation mechanism for "Objective" #322

Merged
merged 1 commit into from
Oct 24, 2015
Merged

Add translation mechanism for "Objective" #322

merged 1 commit into from
Oct 24, 2015

Conversation

alexandear
Copy link
Contributor

Resolves #321

pcottle
pcottle reviewed Oct 24, 2015
View reviewed changes
src/js/intl/strings.js
@@ -917,6 +917,12 @@ exports.strings = {
'ru_RU': 'Спрятать цель'
},
///////////////////////////////////////////////////////////////////////////
'objective-button': {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep youre right -- i guess i had never wrapped this in an intl call! I thought maybe the token was in this file and I just missed it in the transition

pcottle added a commit that referenced this pull request Oct 24, 2015
@pcottle
Merge pull request #322 from alexandear/objective
bd524af 
Add translation mechanism for "Objective"
@pcottle pcottle merged commit bd524af into pcottle:master Oct 24, 2015
@pcottle
Copy link
Owner

pcottle commented Oct 24, 2015

Thanks so much @alexandear, officially a contributor to the project 🎉 just pushed the site with your updates:

To [email protected]:pcottle/learnGitBranching.git
   db2cff1..30c8a26  gh-pages -> gh-pages
Switched to branch 'master'
Your branch is up-to-date with 'origin/master'.
Done, without errors.

@alexandear
Copy link
Contributor Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @pcottle