[gen3] hal: fixes the issue that UARTE RX may loss data. #2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avtolstoy
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
@XuGuohui I'm approving this and we are going to merge and release this as part of 4.2.0 even if we may still be seeing some potential problems. We can continue looking into them, but this should provide enough of an improvement to previously much more broken behavior.
technobly
pushed a commit
that referenced
this pull request
Sep 21, 2023
[gen3] hal: fixes the issue that UARTE RX may loss data.
This was referenced Sep 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check out: #2685
The main idea to fix this issue is to make sure the ENDRX event is handled ASAP so that the UARTE receiver is started in time to accept incoming data.
Completeness